components/autofill/core/common/password_form.h - Issue 1096983002: Update usages of std::map to use ScopedPtrMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 1096983002: Update usages of std::map to use ScopedPtrMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@passwordmanager-scopedmemory

Patch Set: Fix Mac compile. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/gsm_sms_client.cc ('K') | « chromeos/dbus/shill_profile_client.cc ('k') | components/autofill/core/common/password_form_fill_data_unittest.cc » ('j') | ui/gfx/image/image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index 96633264b01e32a407cdf3e9d150ee763faad6f0..f246e73f7ad833dbc5ac2c68263a68e8caee5a84 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -9,6 +9,8 @@

#include <string>

#include <vector>

+#include "base/containers/scoped_ptr_map.h"

+#include "base/memory/scoped_ptr.h"

#include "base/time/time.h"

#include "components/autofill/core/common/form_data.h"

#include "url/gurl.h"

@@ -280,8 +282,9 @@ struct PasswordForm {

};

// Map username to PasswordForm* for convenience. See password_form_manager.h.

-typedef std::map<base::string16, PasswordForm*> PasswordFormMap;

+typedef ScopedPtrMap<base::string16, scoped_ptr<PasswordForm>> PasswordFormMap;

+// Like PasswordFormMap, but with weak (not owned) pointers.

typedef std::map<base::string16, const PasswordForm*> ConstPasswordFormMap;

// For testing.