Update usages of std::map to use ScopedPtrMap.

apps/saved_files_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/saved_files_service.h"
 
 #include <algorithm>
+#include <map>
 
 #include "apps/saved_files_service_factory.h"
 #include "base/basictypes.h"
-#include "base/containers/hash_tables.h"
+#include "base/containers/scoped_ptr_hash_map.h"
 #include "base/value_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_util.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/common/permissions/api_permission.h"
@@ skipping 148 matching lines @@
   // will almost never do any real work.
   void MaybeCompactSequenceNumbers();
 
   void LoadSavedFileEntriesFromPreferences();
 
   Profile* profile_;
   const std::string extension_id_;
 
   // Contains all file entries that have been registered, keyed by ID. Owns
   // values.
-  base::hash_map<std::string, SavedFileEntry*> registered_file_entries_;
-  STLValueDeleter<base::hash_map<std::string, SavedFileEntry*> >
-      registered_file_entries_deleter_;
+  base::ScopedPtrHashMap<std::string, scoped_ptr<SavedFileEntry>>
+      registered_file_entries_;
 
   // The queue of file entries that have been retained, keyed by
   // sequence_number. Values are a subset of values in registered_file_entries_.
   // This should be kept in sync with file entries stored in extension prefs.
   std::map<int, SavedFileEntry*> saved_file_lru_;
 
   DISALLOW_COPY_AND_ASSIGN(SavedFiles);
 };
 
 // static
 SavedFilesService* SavedFilesService::Get(Profile* profile) {
   return SavedFilesServiceFactory::GetForProfile(profile);
 }
 
-SavedFilesService::SavedFilesService(Profile* profile)
-    : extension_id_to_saved_files_deleter_(&extension_id_to_saved_files_),
-      profile_(profile) {
+SavedFilesService::SavedFilesService(Profile* profile) : profile_(profile) {
   registrar_.Add(this,
                  extensions::NOTIFICATION_EXTENSION_HOST_DESTROYED,
                  content::NotificationService::AllSources());
   registrar_.Add(this,
                  chrome::NOTIFICATION_APP_TERMINATING,
                  content::NotificationService::AllSources());
 }
 
 SavedFilesService::~SavedFilesService() {}
 
@@ skipping 60 matching lines @@
   }
 }
 
 void SavedFilesService::ClearQueue(const extensions::Extension* extension) {
   ClearSavedFileEntries(ExtensionPrefs::Get(profile_), extension->id());
   Clear(extension->id());
 }
 
 SavedFilesService::SavedFiles* SavedFilesService::Get(
     const std::string& extension_id) const {
-  std::map<std::string, SavedFiles*>::const_iterator it =
+  ScopedPtrMap<std::string, scoped_ptr<SavedFiles>>::const_iterator it =
       extension_id_to_saved_files_.find(extension_id);
   if (it != extension_id_to_saved_files_.end())
     return it->second;
 
   return NULL;
 }
 
 SavedFilesService::SavedFiles* SavedFilesService::GetOrInsert(
     const std::string& extension_id) {
   SavedFiles* saved_files = Get(extension_id);
   if (saved_files)
     return saved_files;
 
-  saved_files = new SavedFiles(profile_, extension_id);
-  extension_id_to_saved_files_.insert(
-      std::make_pair(extension_id, saved_files));
+  scoped_ptr<SavedFiles> scoped_saved_files(
+      new SavedFiles(profile_, extension_id));
+  saved_files = scoped_saved_files.get();
+  extension_id_to_saved_files_.insert(extension_id, scoped_saved_files.Pass());
   return saved_files;
 }
 
 void SavedFilesService::Clear(const std::string& extension_id) {
-  std::map<std::string, SavedFiles*>::iterator it =
-      extension_id_to_saved_files_.find(extension_id);
-  if (it != extension_id_to_saved_files_.end()) {
-    delete it->second;
-    extension_id_to_saved_files_.erase(it);
-  }
+  extension_id_to_saved_files_.erase(extension_id);
 }
 
 SavedFilesService::SavedFiles::SavedFiles(Profile* profile,
                                           const std::string& extension_id)
-    : profile_(profile),
-      extension_id_(extension_id),
-      registered_file_entries_deleter_(&registered_file_entries_) {
+    : profile_(profile), extension_id_(extension_id) {
   LoadSavedFileEntriesFromPreferences();
 }
 
 SavedFilesService::SavedFiles::~SavedFiles() {}
 
 void SavedFilesService::SavedFiles::RegisterFileEntry(
     const std::string& id,
     const base::FilePath& file_path,
     bool is_directory) {
   if (ContainsKey(registered_file_entries_, id))
     return;
 
-  registered_file_entries_.insert(
-      std::make_pair(id, new SavedFileEntry(id, file_path, is_directory, 0)));
+  registered_file_entries_.add(
+      id, make_scoped_ptr(new SavedFileEntry(id, file_path, is_directory, 0)));
 }
 
 void SavedFilesService::SavedFiles::EnqueueFileEntry(const std::string& id) {
-  base::hash_map<std::string, SavedFileEntry*>::iterator it =
-      registered_file_entries_.find(id);
+  auto it = registered_file_entries_.find(id);

[tapted, 2015/06/19 00:12:01]

`it` becomes a shadowed variable just below, which is confusing. What about

SavedFileEntry* file_entry = registered_file_entries_.get(id);
DCHECK(file_entry);

(or even skip the DCHECK since it's immediately dereferenced and would crash
regardless)

[Matt Giuca, 2015/06/19 04:03:25]

I'm hesitant to use get() because there's no get() on std::hash_map, and we're
trying to migrate to that later on. (So it probably should be considered
deprecated.)

Shadowing happens in similar ways throughout this file and I don't want to go
fixing even minor unrelated issues in a CL of this breadth. I'll just leave it.

   DCHECK(it != registered_file_entries_.end());
 
   SavedFileEntry* file_entry = it->second;
   int old_sequence_number = file_entry->sequence_number;
   if (!saved_file_lru_.empty()) {
     // Get the sequence number after the last file entry in the LRU.
     std::map<int, SavedFileEntry*>::reverse_iterator it =
         saved_file_lru_.rbegin();
     if (it->second == file_entry)
       return;
@@ skipping 20 matching lines @@
   }
   MaybeCompactSequenceNumbers();
 }
 
 bool SavedFilesService::SavedFiles::IsRegistered(const std::string& id) const {
   return ContainsKey(registered_file_entries_, id);
 }
 
 const SavedFileEntry* SavedFilesService::SavedFiles::GetFileEntry(
     const std::string& id) const {
-  base::hash_map<std::string, SavedFileEntry*>::const_iterator it =
-      registered_file_entries_.find(id);
+  auto it = registered_file_entries_.find(id);

[tapted, 2015/06/19 00:12:01]

nit: just `return registered_file_entries_.get(id);` (this method looks
identical)

[Matt Giuca, 2015/06/19 04:03:25]

As above, I think we should consider get() to be deprecated since it won't be
available on std::hash_map.

   if (it == registered_file_entries_.end())
     return NULL;
 
   return it->second;
 }
 
 std::vector<SavedFileEntry> SavedFilesService::SavedFiles::GetAllFileEntries()
     const {
   std::vector<SavedFileEntry> result;
-  for (base::hash_map<std::string, SavedFileEntry*>::const_iterator it =
-           registered_file_entries_.begin();
-       it != registered_file_entries_.end();
-       ++it) {
+  for (auto it = registered_file_entries_.begin();
+       it != registered_file_entries_.end(); ++it) {
     result.push_back(*it->second);
   }
   return result;
 }
 
 void SavedFilesService::SavedFiles::MaybeCompactSequenceNumbers() {
   DCHECK_GE(g_max_sequence_number, 0);
   DCHECK_GE(static_cast<size_t>(g_max_sequence_number),
             g_max_saved_file_entries);
   std::map<int, SavedFileEntry*>::reverse_iterator it =
@@ skipping 27 matching lines @@
   }
 }
 
 void SavedFilesService::SavedFiles::LoadSavedFileEntriesFromPreferences() {
   ExtensionPrefs* prefs = ExtensionPrefs::Get(profile_);
   std::vector<SavedFileEntry> saved_entries =
       GetSavedFileEntries(prefs, extension_id_);
   for (std::vector<SavedFileEntry>::iterator it = saved_entries.begin();
        it != saved_entries.end();
        ++it) {
-    SavedFileEntry* file_entry = new SavedFileEntry(*it);
-    registered_file_entries_.insert(std::make_pair(file_entry->id, file_entry));
+    scoped_ptr<SavedFileEntry> file_entry(new SavedFileEntry(*it));
+    const std::string& id = file_entry->id;
     saved_file_lru_.insert(
-        std::make_pair(file_entry->sequence_number, file_entry));
+        std::make_pair(file_entry->sequence_number, file_entry.get()));
+    registered_file_entries_.add(id, file_entry.Pass());
   }
 }
 
 // static
 void SavedFilesService::SetMaxSequenceNumberForTest(int max_value) {
   g_max_sequence_number = max_value;
 }
 
 // static
 void SavedFilesService::ClearMaxSequenceNumberForTest() {
   g_max_sequence_number = kMaxSequenceNumber;
 }
 
 // static
 void SavedFilesService::SetLruSizeForTest(int size) {
   g_max_saved_file_entries = size;
 }
 
 // static
 void SavedFilesService::ClearLruSizeForTest() {
   g_max_saved_file_entries = kMaxSavedFileEntries;
 }
 
 }  // namespace apps