Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1096923003: working on initial winding for cubics (Closed)

Created:
5 years, 8 months ago by caryclark
Modified:
5 years, 8 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

working on initial winding for cubics Path ops works well for all tests except for cubics. Isolate failures caused by cubics, and do a better job of computing the initial winding for cubics. TBR=reed@google.com BUG=skia:3588 Committed: https://skia.googlesource.com/skia/+/03b03cad01628146bbb8d4f33c073bd0c77ee558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5170 lines, -455 lines) Patch
M src/pathops/SkOpAngle.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpContour.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpContour.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/pathops/SkOpSegment.h View 6 chunks +14 lines, -4 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 7 chunks +40 lines, -69 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsConic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 2 chunks +22 lines, -19 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 3 chunks +11 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 7 chunks +83 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsCurve.h View 2 chunks +18 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 4 chunks +14 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsPoint.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 4 chunks +34 lines, -19 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/PathOpsDCubicTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/PathOpsDebug.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 2 chunks +25 lines, -4 lines 0 comments Download
M tests/PathOpsIssue3651.cpp View 1 chunk +241 lines, -1 line 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 3 chunks +32 lines, -25 lines 0 comments Download
M tests/PathOpsOpLoopThreadedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 6 chunks +355 lines, -6 lines 0 comments Download
M tools/pathops_sorter.htm View 2 chunks +21 lines, -3 lines 0 comments Download
M tools/pathops_visualizer.htm View 18 chunks +4204 lines, -266 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096923003/1
5 years, 8 months ago (2015-04-23 15:50:06 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 15:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096923003/1
5 years, 8 months ago (2015-04-23 16:13:14 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:13:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/03b03cad01628146bbb8d4f33c073bd0c77ee558

Powered by Google App Engine
This is Rietveld 408576698