Support Dynamic type with a prefix.

lib/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class LocalPlaceholder implements Hashable {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
   int hashCode() => identifier.hashCode();
   String toString() =>
@@ skipping 433 matching lines @@
           Identifier receiver = send.receiver;
           Identifier selector = send.selector;
           getConstructor() =>
               (element as ClassElement).lookupConstructor(
                   receiver.source, selector.source);
           hasPrefix = (element is TypedefElement) || getConstructor() === null;
           if (!hasPrefix) target = receiver;
         }
       }
       // TODO(antonm): is there a better way to detect unresolved types?
-      if (type.element !== compiler.types.dynamicType.element) {
-        // Corner case: dart:core type with a prefix.
-        // Most probably there are some additional problems with
-        // coreLibPrefix.Dynamic and coreLibPrefix.topLevels.
-        if (type.element.getLibrary() === coreLibrary && hasPrefix) {
-          makeNullPlaceholder(node.typeName.receiver);
+      // Corner case: dart:core type with a prefix.
+      // Most probably there are some additional problems with
+      // coreLibPrefix.topLevels.
+      Element typeElement = type.element;
+      Element dynamicTypeElement = compiler.types.dynamicType.element;
+      if (hasPrefix &&
+        (typeElement.getLibrary() === coreLibrary ||

[Roman, 2012/09/24 15:24:57]

if continuation is usually indented by 4 spaces, otherwise it's difficult to
tell where the body starts.

[Anton Muhin, 2012/09/24 16:00:22]

Done.

+        typeElement === dynamicTypeElement)) {
+        makeNullPlaceholder(node.typeName.receiver);
+      } else {
+        if (typeElement !== dynamicTypeElement) {
+          makeTypePlaceholder(target, type);
         } else {
-          makeTypePlaceholder(target, type);
+          if (!isDynamicType(node)) makeUnresolvedPlaceholder(target);
         }
-      } else {
-        if (!isDynamicType(node)) makeUnresolvedPlaceholder(target);
       }
     }
     node.visitChildren(this);
   }
 
   visitVariableDefinitions(VariableDefinitions node) {
     // Collect only local placeholders.
     for (Node definition in node.definitions.nodes) {
       Element definitionElement = treeElements[definition];
       // definitionElement may be null if we're inside variable definitions
@@ skipping 124 matching lines @@
 
   visitBlock(Block node) {
     for (Node statement in node.statements.nodes) {
       if (statement is VariableDefinitions) {
         makeVarDeclarationTypePlaceholder(statement);
       }
     }
     node.visitChildren(this);
   }
 }