Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 10969068: Merge 128982 - MediaStream API: Rename the RTCIceServer uri parameter to url. (Closed)

Created:
8 years, 3 months ago by karen
Modified:
8 years, 3 months ago
Reviewers:
Tommy Widenflycht
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 128982 - MediaStream API: Rename the RTCIceServer uri parameter to url. https://bugs.webkit.org/show_bug.cgi?id=97086 Reviewed by Hajime Morita. Source/WebCore: Either the standard has changed or I can't read. http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members Existing tests changed to cover this patch. * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::parseConfiguration): LayoutTests: * fast/mediastream/RTCPeerConnection-expected.txt: * fast/mediastream/RTCPeerConnection.html: * fast/mediastream/constructors-expected.txt: * fast/mediastream/constructors.html: TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M LayoutTests/fast/mediastream/RTCPeerConnection.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/mediastream/constructors.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/mediastream/constructors-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
8 years, 3 months ago (2012-09-24 13:49:17 UTC) #1
Tommy Widenflycht
8 years, 3 months ago (2012-09-24 13:51:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698