Issue 10969053: Extensions Docs Server: Show callbacks for events

Issue 10969053: Extensions Docs Server: Show callbacks for events (Closed)

Created:
8 years, 3 months ago by cduvall

Modified:
8 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Matt Tytel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extensions Docs Server: Show callbacks for events Events were not showing callback functions in the docs. BUG=149672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158424

Patch Set 2 : put callback on its own line #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
M	chrome/common/extensions/docs/server2/handlebar_dict_generator.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/templates/private/event.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm http://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs/templates/private/event.html File chrome/common/extensions/docs/templates/private/event.html (right): http://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs/templates/private/event.html#newcode31 chrome/common/extensions/docs/templates/private/event.html:31: {{?callback}}{{+partials.callback}}{{/}} nit: put {{+partials.callback}} on its own line ...

8 years, 3 months ago (2012-09-24 00:49:01 UTC) #2

not at google - send to devlin

http://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs/templates/private/event.html File chrome/common/extensions/docs/templates/private/event.html (right): http://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs/templates/private/event.html#newcode31 chrome/common/extensions/docs/templates/private/event.html:31: {{?callback}}{{+partials.callback}}{{/}} On 2012/09/24 00:49:01, kalman wrote: > nit: put ...

8 years, 3 months ago (2012-09-24 00:49:27 UTC) #3

cduvall

8 years, 3 months ago (2012-09-24 22:29:03 UTC) #4

https://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/templates/private/event.html (right):

https://codereview.chromium.org/10969053/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/templates/private/event.html:31:
{{?callback}}{{+partials.callback}}{{/}}
On 2012/09/24 00:49:27, kalman wrote:
> On 2012/09/24 00:49:01, kalman wrote:
> > nit: put {{+partials.callback}} on its own line so that it doesn't get
> inlined.
> 
> ok, don't know why i prefixed that with "nit", because it isn't a nit :)

Done.

Expand Messages | Collapse Messages