Create a new URLRequestJobFactory for isolated request contexts.

content/browser/storage_partition_impl_map.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/storage_partition_impl_map.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/stl_util.h"
@@ skipping 126 matching lines @@
 };
 
 void InitializeURLRequestContext(
     net::URLRequestContextGetter* context_getter,
     AppCacheService* appcache_service,
     FileSystemContext* file_system_context,
     ChromeBlobStorageContext* blob_storage_context) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (!context_getter)
     return;  // tests.
+
+  // This code only modifies the URLRequestJobFactory on the context
+  // to handle blob: URLs, filesystem: URLs, and to let AppCache intercept
+  // the appropriate requests.  This is in addition to the slew of other
+  // initializtion is done in during creation of the URLRequestContext.

[Charlie Reis, 2012/09/20 22:57:46]

nit: that is

[awong, 2012/09/20 23:16:46]

Done.

+  // We cannot yet centralize this code because URLRequestContext needs
+  // to be created before the StoragePartition context.
+  //
+  // TODO(ajwong): Fix the ordering so all the initialization is in one spot.
   net::URLRequestContext* context = context_getter->GetURLRequestContext();
   net::URLRequestJobFactory* job_factory =
       const_cast<net::URLRequestJobFactory*>(context->job_factory());
+
+  // Note: if this is called twice with 2 request contexts that share one job
+  // factory (as is the case with a media request context and its related
+  // normal request context) then this will early exit.
   if (job_factory->IsHandledProtocol(chrome::kBlobScheme))
-    return;  // Already initialized this RequestContext.
+    return;  // Already initialized this JobFactory.
 
   bool set_protocol = job_factory->SetProtocolHandler(
       chrome::kBlobScheme,
       new BlobProtocolHandler(
           blob_storage_context->controller(),
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)));
   DCHECK(set_protocol);
   set_protocol = job_factory->SetProtocolHandler(
       chrome::kFileSystemScheme,
       CreateFileSystemProtocolHandler(file_system_context));
@@ skipping 84 matching lines @@
     // Add content's URLRequestContext's hooks.
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(
             &InitializeURLRequestContext,
             make_scoped_refptr(partition->GetURLRequestContext()),
             make_scoped_refptr(partition->GetAppCacheService()),
             make_scoped_refptr(partition->GetFileSystemContext()),
             make_scoped_refptr(
                 ChromeBlobStorageContext::GetFor(browser_context_))));
-    BrowserThread::PostTask(
-        BrowserThread::IO, FROM_HERE,
-        base::Bind(
-            &InitializeURLRequestContext,
-            make_scoped_refptr(partition->GetMediaURLRequestContext()),
-            make_scoped_refptr(partition->GetAppCacheService()),
-            make_scoped_refptr(partition->GetFileSystemContext()),
-            make_scoped_refptr(
-                ChromeBlobStorageContext::GetFor(browser_context_))));
+
+    // We do not call InitializeURLRequestContext() for media contexts because,
+    // other than the HTTP cache, the media contexts share the same backing
+    // objects as their associated "normal" request context.  Thus, the previous
+    // call serves to initialize the media request context for this storage
+    // partition as well.
   }
 }
 
 }  // namespace content