lib/compiler/implementation/ssa/codegen.dart - Issue 10969014: Do not pass the name of the is check if it's not required (typically for primitive types).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10969014: Do not pass the name of the is check if it's not required (typically for primitive types). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/codegen.dart

===================================================================

--- lib/compiler/implementation/ssa/codegen.dart (revision 12681)

+++ lib/compiler/implementation/ssa/codegen.dart (working copy)

@@ -2462,8 +2462,10 @@

List<js.Expression> arguments = <js.Expression>[];

use(node.checkedInput);

arguments.add(pop());

- String additionalArgument = backend.namer.operatorIs(element);

- arguments.add(new js.LiteralString("'$additionalArgument'"));

+ if (helperElement.computeSignature(compiler).parameterCount != 1) {

+ String additionalArgument = backend.namer.operatorIs(element);

+ arguments.add(new js.LiteralString("'$additionalArgument'"));

+ }

String helperName = backend.namer.isolateAccess(helperElement);

push(new js.Call(new js.VariableUse(helperName), arguments));

} else {

« no previous file with comments | « lib/compiler/implementation/js_backend/emitter.dart ('k') | no next file » | no next file with comments »