Convert PrefSyncStatus into PrefRegistrationFlags

base/prefs/pref_service.cc

Index: base/prefs/pref_service.cc
diff --git a/base/prefs/pref_service.cc b/base/prefs/pref_service.cc
index 5afb5ea7c67496fcbc22148af7f77d51fd702ca9..bccea068fcb00fbca1ac5534bd5f72ecc9c7d919 100644
--- a/base/prefs/pref_service.cc
+++ b/base/prefs/pref_service.cc
@@ -316,6 +316,16 @@ const base::Value* PrefService::GetDefaultPrefValue(
   return value;
 }
 
+uint32 PrefService::GetRegistrationFlags(const std::string& path) const {
+  DCHECK(CalledOnValidThread());
+  const auto& it = pref_registry_->registration_flags().find(path);
+  if (it == pref_registry_->registration_flags().end()) {

[Mattias Nissler (ping if slow), 2015/04/20 09:33:34]

I'd prefer having this logic in PrefRegistry, and the latter exposing a
GetRegistrationFlags(const std::string& path) function which you can call here.
Doing so would keep flag handling/defaulting in one place.

[raymes, 2015/04/21 07:58:54]

Sounds good but the function isn't used at all for now so I'll just remove it.

+    NOTREACHED() << "Registration flags missing for pref: " << path;
+    return PrefRegistry::NO_REGISTRATION_FLAGS;
+  }
+  return it->second;
+}
+
 const base::ListValue* PrefService::GetList(const std::string& path) const {
   DCHECK(CalledOnValidThread());