Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: base/prefs/pref_registry.cc

Issue 1096833003: Convert PrefSyncStatus into PrefRegistrationFlags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_registry.h" 5 #include "base/prefs/pref_registry.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/default_pref_store.h" 8 #include "base/prefs/default_pref_store.h"
9 #include "base/prefs/pref_store.h" 9 #include "base/prefs/pref_store.h"
10 #include "base/stl_util.h"
10 #include "base/values.h" 11 #include "base/values.h"
11 12
12 PrefRegistry::PrefRegistry() 13 PrefRegistry::PrefRegistry()
13 : defaults_(new DefaultPrefStore()) { 14 : defaults_(new DefaultPrefStore()) {
14 } 15 }
15 16
16 PrefRegistry::~PrefRegistry() { 17 PrefRegistry::~PrefRegistry() {
17 } 18 }
18 19
19 scoped_refptr<PrefStore> PrefRegistry::defaults() { 20 scoped_refptr<PrefStore> PrefRegistry::defaults() {
(...skipping 14 matching lines...) Expand all
34 const base::Value* current_value = NULL; 35 const base::Value* current_value = NULL;
35 DCHECK(defaults_->GetValue(pref_name, &current_value)) 36 DCHECK(defaults_->GetValue(pref_name, &current_value))
36 << "Setting default for unregistered pref: " << pref_name; 37 << "Setting default for unregistered pref: " << pref_name;
37 DCHECK(value->IsType(current_value->GetType())) 38 DCHECK(value->IsType(current_value->GetType()))
38 << "Wrong type for new default: " << pref_name; 39 << "Wrong type for new default: " << pref_name;
39 40
40 defaults_->ReplaceDefaultValue(pref_name, make_scoped_ptr(value)); 41 defaults_->ReplaceDefaultValue(pref_name, make_scoped_ptr(value));
41 } 42 }
42 43
43 void PrefRegistry::RegisterPreference(const std::string& path, 44 void PrefRegistry::RegisterPreference(const std::string& path,
44 base::Value* default_value) { 45 base::Value* default_value,
46 uint32 flags) {
45 base::Value::Type orig_type = default_value->GetType(); 47 base::Value::Type orig_type = default_value->GetType();
46 DCHECK(orig_type != base::Value::TYPE_NULL && 48 DCHECK(orig_type != base::Value::TYPE_NULL &&
47 orig_type != base::Value::TYPE_BINARY) << 49 orig_type != base::Value::TYPE_BINARY) <<
48 "invalid preference type: " << orig_type; 50 "invalid preference type: " << orig_type;
49 DCHECK(!defaults_->GetValue(path, NULL)) << 51 DCHECK(!defaults_->GetValue(path, NULL)) <<
50 "Trying to register a previously registered pref: " << path; 52 "Trying to register a previously registered pref: " << path;
53 DCHECK(!ContainsKey(registration_flags_, path)) <<
54 "Trying to register a previously registered pref: " << path;
51 55
52 defaults_->SetDefaultValue(path, make_scoped_ptr(default_value)); 56 defaults_->SetDefaultValue(path, make_scoped_ptr(default_value));
57 registration_flags_[path] = flags;
53 } 58 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698