Kill overloaded cast operators in CJS_Value.

fpdfsdk/src/javascript/Field.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 1054 matching lines @@
                 }
                 else if (vp.IsArrayObject())
                 {
                         CJS_Array SelArray(m_isolate);
                         CJS_Value SelValue(m_isolate);
                         int iSelecting;
                         vp >> SelArray;
                         for (int i=0,sz=SelArray.GetLength(); i<sz; i++)
                         {
                                 SelArray.GetElement(i,SelValue);
-                                iSelecting = (FX_INT32)SelValue;
+                                iSelecting = SelValue.ToInt();
                                 array.Add(iSelecting);
                         }
                 }
                 
                 if (m_bDelay)
                 {
                         AddDelay_WordArray(FP_CURRENTVALUEINDICES, array);
                 }
                 else
                 {
@@ skipping 1282 matching lines @@
 
                 CJS_Array rcArray(m_isolate);
                 vp >> rcArray;
                 CJS_Value Upper_Leftx(m_isolate), Upper_Lefty(m_isolate), Lower_Rightx(m_isolate), Lower_Righty(m_isolate);
                 rcArray.GetElement(0, Upper_Leftx);
                 rcArray.GetElement(1, Upper_Lefty);
                 rcArray.GetElement(2, Lower_Rightx);
                 rcArray.GetElement(3, Lower_Righty);
 
                 FX_FLOAT pArray[4] = {0.0f,0.0f,0.0f,0.0f};
-                pArray[0] = (FX_FLOAT)(FX_INT32)Upper_Leftx;
-                pArray[1] = (FX_FLOAT)(FX_INT32)Lower_Righty;
-                pArray[2] = (FX_FLOAT)(FX_INT32)Lower_Rightx;
-                pArray[3] = (FX_FLOAT)(FX_INT32)Upper_Lefty;
+                pArray[0] = (FX_FLOAT)Upper_Leftx.ToInt();
+                pArray[1] = (FX_FLOAT)Lower_Righty.ToInt();
+                pArray[2] = (FX_FLOAT)Lower_Rightx.ToInt();
+                pArray[3] = (FX_FLOAT)Upper_Lefty.ToInt();
 
                 CPDF_Rect crRect(pArray);
 
                 if (m_bDelay)
                 {
                         AddDelay_Rect(FP_RECT, crRect);
                 }
                 else
                 {
                         Field::SetRect(m_pDocument, m_FieldName, m_nFormControlIndex, crRect);
@@ skipping 686 matching lines @@
                 CJS_WideStringArray strArray;
 
                 if (vp.IsArrayObject())
                 {
                         CJS_Array ValueArray(m_isolate);
                         vp.ConvertToArray(ValueArray);
                         for (int i = 0,sz = ValueArray.GetLength(); i < sz; i++)
                         {
                                 CJS_Value ElementValue(m_isolate);
                                 ValueArray.GetElement(i, ElementValue);
-                                strArray.Add(ElementValue.operator CFX_WideString());
+                                strArray.Add(ElementValue.ToCFXWideString());
                         }
                 }
                 else
                 {
                         CFX_WideString swValue;
                         vp >> swValue;
 
                         strArray.Add(swValue);
                 }
 
@@ skipping 43 matching lines @@
                         {
                                 if (pFormField->CountSelectedItems() > 1)
                                 {
                                         CJS_Array ValueArray(m_isolate);
                                         CJS_Value ElementValue(m_isolate);
                                         int iIndex;
                                         for (int i = 0, sz = pFormField->CountSelectedItems(); i < sz; i++)
                                         {
                                                 iIndex = pFormField->GetSelectedIndex(i);
                                                 ElementValue = pFormField->GetOptionValue(iIndex);
-                                                if (FXSYS_wcslen((FX_LPCWSTR)ElementValue.operator CFX_WideString()) == 0)
+                                                if (FXSYS_wcslen(ElementValue.ToCFXWideString().c_str()) == 0)
                                                         ElementValue = pFormField->GetOptionLabel(iIndex);
                                                 ValueArray.SetElement(i, ElementValue);
                                         }
                                         vp << ValueArray;
                                 }
                                 else
                                 {
                                         CFX_WideString swValue = pFormField->GetValue();
                                 
                                         double dRet;
@@ skipping 204 matching lines @@
         return TRUE;
 }
 
 
 FX_BOOL Field::buttonGetCaption(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         int nface = 0;
         int iSize = params.size();
-        if ( iSize >= 1)
-                nface = (FX_INT32) params[0];
+        if (iSize >= 1)
+                nface = params[0].ToInt();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
         
         if (pFormField->GetFieldType() != FIELDTYPE_PUSHBUTTON)
                 return FALSE;
@@ skipping 14 matching lines @@
 }
 
 //#pragma warning(disable: 4800)
 
 FX_BOOL Field::buttonGetIcon(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         int nface = 0;
         int iSize = params.size();
-        if ( iSize >= 1)
-                nface = (FX_INT32) params[0];
+        if (iSize >= 1)
+                nface = params[0].ToInt();
         
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
         
         if (pFormField->GetFieldType() != FIELDTYPE_PUSHBUTTON)
                 return FALSE;
@@ skipping 87 matching lines @@
         return FALSE;
 }
 
 FX_BOOL Field::checkThisBox(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         if (!m_bCanSet) return FALSE;
 
         int iSize = params.size();
-        int nWidget = -1;
-        if ( iSize >= 1)
-                nWidget= (FX_INT32) params[0];
-        else
+        if (iSize < 1)
                 return FALSE;
+
+        int nWidget = params[0].ToInt();
+
         FX_BOOL bCheckit = TRUE;
-        if ( iSize >= 2)
-                bCheckit = params[1];
-
+        if (iSize >= 2)
+                bCheckit = params[1].ToBool();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
-        
+
         if (pFormField->GetFieldType() != FIELDTYPE_CHECKBOX && pFormField->GetFieldType() != FIELDTYPE_RADIOBUTTON)
-                return FALSE;   
+                return FALSE;
         if(nWidget <0 || nWidget >= pFormField->CountControls())
                 return FALSE;
         if (pFormField->GetFieldType() == FIELDTYPE_RADIOBUTTON)
                 pFormField->CheckControl(nWidget, bCheckit, TRUE);
         else
                 pFormField->CheckControl(nWidget, bCheckit, TRUE);
 
         UpdateFormField(m_pDocument, pFormField, TRUE, TRUE, TRUE);
-
         return TRUE;
 }
 
 FX_BOOL Field::clearItems(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Field::defaultIsChecked(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         if (!m_bCanSet) return FALSE;
 
         int iSize = params.size();
-        int nWidget = -1;
-        if ( iSize >= 1)
-                nWidget= (FX_INT32) params[0];
-        else
+        if (iSize < 1)
                 return FALSE;
-        //FX_BOOL bIsDefaultChecked = TRUE;
-        //if ( iSize >= 2)
-        //      bIsDefaultChecked =  params[1];
+
+        int nWidget = params[0].ToInt();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
 
         if(nWidget <0 || nWidget >= pFormField->CountControls())
         {
@@ skipping 75 matching lines @@
         }
 
         vRet = FormFieldArray;
         swSort.RemoveAll();
         return TRUE;
 }
         
 FX_BOOL Field::getItemAt(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
+        int iSize = params.size();
 
         int nIdx = -1;
-        if (params.size() >=1)
-                nIdx = (FX_INT32) params[0];
+        if (iSize >= 1)
+                nIdx = params[0].ToInt();
+
         FX_BOOL bExport = TRUE;
-        int iSize = params.size();
-        if ( iSize >= 2)
-        {
-                bExport =(FX_BOOL) params[1];
-        }
+        if (iSize >= 2)
+                bExport = params[1].ToBool();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
 
         if ((pFormField->GetFieldType() == FIELDTYPE_LISTBOX)
                 || (pFormField->GetFieldType() == FIELDTYPE_COMBOBOX))
@@ skipping 25 matching lines @@
 FX_BOOL Field::insertItemAt(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL Field::isBoxChecked(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         int nIndex = -1;
-        if (params.size() >=1)
-                nIndex = (FX_INT32) params[0];
+        if (params.size() >= 1)
+                nIndex = params[0].ToInt();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
 
         if(nIndex <0 || nIndex >= pFormField->CountControls())
         {
@@ skipping 13 matching lines @@
                 vRet = FALSE;
 
         return TRUE;
 }
 
 FX_BOOL Field::isDefaultChecked(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         ASSERT(m_pDocument != NULL);
 
         int nIndex = -1;
-        if (params.size() >=1)
-                nIndex = (FX_INT32) params[0];
+        if (params.size() >= 1)
+                nIndex = params[0].ToInt();
 
         CFX_PtrArray FieldArray;
         GetFormFields(m_FieldName,FieldArray);
         if (FieldArray.GetSize() <= 0) return FALSE;
 
         CPDF_FormField* pFormField = (CPDF_FormField*)FieldArray.ElementAt(0);
         ASSERT(pFormField != NULL);
 
         if(nIndex <0 || nIndex >= pFormField->CountControls())
         {
@@ skipping 345 matching lines @@
 
 #define JS_FIELD_MINWIDTH       1
 #define JS_FIELD_MINHEIGHT      1
 
 void Field::AddField(CPDFSDK_Document* pDocument, int nPageIndex, int nFieldType,
                                                         const CFX_WideString& sName, const CPDF_Rect& rcCoords)
 {
         //Not supported.
 }