Kill overloaded cast operators in CJS_Value.

fpdfsdk/src/javascript/color.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 86 matching lines @@
                 break;
         }
 }
 
 void color::ConvertArrayToPWLColor(CJS_Array& array, CPWL_Color& color)
 {
         int nArrayLen = array.GetLength();
         if (nArrayLen < 1) return;
 
         CJS_Value value(array.GetIsolate());
-        CFX_ByteString sSpace;
         array.GetElement(0, value);
-        sSpace = value;
+        CFX_ByteString sSpace = value.ToCFXByteString();
 
         double d1 = 0;
         double d2 = 0;
         double d3 = 0;
         double d4 = 0;
 
         if (nArrayLen > 1)
         {
                 array.GetElement(1, value);
-                d1 = value;
+                d1 = value.ToDouble();
         }
 
         if (nArrayLen > 2)
         {
                 array.GetElement(2, value);
-                d2 = value;
+                d2 = value.ToDouble();
         }
 
         if (nArrayLen > 3)
         {
                 array.GetElement(3, value);
-                d3 = value;
+                d3 = value.ToDouble();
         }
 
         if (nArrayLen > 4)
         {
                 array.GetElement(4, value);
-                d4 = value;
+                d4 = value.ToDouble();
         }
 
         if (sSpace == "T")
         {
                 color = CPWL_Color(COLORTYPE_TRANSPARENT);
         }
         else if (sSpace == "G")
         {
                 color = CPWL_Color(COLORTYPE_GRAY, (FX_FLOAT)d1);
         }
@@ skipping 44 matching lines @@
 {
         v8::Isolate* isolate = GetIsolate(cc);
         int iSize = params.size();
         if (iSize < 2) return FALSE;
         CJS_Array aSource(isolate);
         if (!params[0].ConvertToArray(aSource)) return FALSE;
 
         CPWL_Color crSource;
         ConvertArrayToPWLColor(aSource, crSource);
 
-        CFX_ByteString sDestSpace = params[1];
+        CFX_ByteString sDestSpace = params[1].ToCFXByteString();
+        int nColorType = COLORTYPE_TRANSPARENT;
 
-        int nColorType = COLORTYPE_TRANSPARENT;
-        
         if (sDestSpace == "T")
         {
                 nColorType = COLORTYPE_TRANSPARENT;
         }
         else if (sDestSpace == "G")
         {
                 nColorType = COLORTYPE_GRAY;
         }
         else if (sDestSpace == "RGB")
         {
@@ skipping 28 matching lines @@
 
         ConvertArrayToPWLColor(array1, color1);
         ConvertArrayToPWLColor(array2, color2);
 
         color1.ConvertColorType(color2.nColorType);
 
         vRet = color1 == color2;
         return TRUE;
 }