lib/compiler/implementation/ssa/bailout.dart - Issue 10968060: Add a value range analysis phase to remove bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/bailout.dart

Issue 10968060: Add a value range analysis phase to remove bounds checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/js_backend/constant_system_javascript.dart ('K') | « lib/compiler/implementation/js_backend/constant_system_javascript.dart ('k') | lib/compiler/implementation/ssa/codegen.dart » ('j') | lib/compiler/implementation/ssa/codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/bailout.dart

===================================================================

--- lib/compiler/implementation/ssa/bailout.dart (revision 12781)

+++ lib/compiler/implementation/ssa/bailout.dart (working copy)

@@ -26,7 +26,7 @@

}

void add(HInstruction instruction) {

- // If the instruction is a type guard, we add its checked input

+ // If the instruction is a check, we add its checked input

// instead. This allows sharing the same environment between

// different type guards.

@@ -34,7 +34,7 @@

// in the live set (because we generate them at use-site), except

// for parameters that are not 'this', which is always passed as

// the receiver.

- if (instruction is HTypeGuard) {

+ if (instruction is HCheck) {

add(instruction.checkedInput);

} else if (!instruction.isCodeMotionInvariant()

|| (instruction is HParameterValue && instruction is !HThis)) {