Fix crash bug of IME extension API.

chromeos/dbus/ibus/ibus_engine_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_IBUS_IBUS_ENGINE_SERVICE_H_
 #define CHROMEOS_DBUS_IBUS_IBUS_ENGINE_SERVICE_H_
 
 #include <string>
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 112 matching lines @@
  public:
   // Following value should be same in
   // http://ibus.googlecode.com/svn/docs/ibus-1.4/ibus-ibustypes.html#IBusPreeditFocusMode
   enum IBusEnginePreeditFocusOutMode {
     IBUS_ENGINE_PREEEDIT_FOCUS_OUT_MODE_CLEAR = 0,
     IBUS_ENGINE_PREEEDIT_FOCUS_OUT_MODE_COMMIT = 1,
   };
 
   virtual ~IBusEngineService();
 
-  // Initializes the engine client. This class takes the ownership of |handler|.
-  virtual void Initialize(IBusEngineHandlerInterface* handler) = 0;
+  // Set a new IBus engine client and old client will be overrided.

[Seigo Nonaka, 2012/09/24 04:16:58]

/Set/Sets/ /overrided/overridden/

[hsumita, 2012/09/24 07:32:59]

Done.

[Seigo Nonaka, 2012/09/24 07:38:45]

Seems not fixed, please revise /overrided/overridden/
On 2012/09/24 07:32:59, hsumita wrote:

[hsumita, 2012/09/24 08:01:16]

It should be fixed on patchset 1.

On 2012/09/24 07:38:45, Seigo Nonaka wrote:

+  // This class doesn't take the ownership of |handler|.
+  virtual void SetEngine(IBusEngineHandlerInterface* handler) = 0;
+
+  // Unset a current IBus engine client.

[Seigo Nonaka, 2012/09/24 04:16:58]

Unsets

[hsumita, 2012/09/24 07:32:59]

Done.

+  virtual void UnsetEngine() = 0;
 
   // Emits RegisterProperties signal.
   virtual void RegisterProperties(
       const ibus::IBusPropertyList& property_list) = 0;
   // Emits UpdatePreedit signal.
   virtual void UpdatePreedit(const ibus::IBusText& ibus_text,
                              uint32 cursor_pos,
                              bool is_visible,
                              IBusEnginePreeditFocusOutMode mode) = 0;
   // Emits UpdateAuxiliaryText signal.
@@ skipping 22 matching lines @@
   // Create() should be used instead.
   IBusEngineService();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(IBusEngineService);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_IBUS_IBUS_ENGINE_SERVICE_H_