Disable right button drag in omnibox

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 87 matching lines @@
 
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE {
     // Pass through the views::Textfield's return value; we don't need to
     // override its behavior.
     bool result = views::Textfield::OnMousePressed(event);
     omnibox_view_->HandleMousePressEvent(event);
     return result;
   }
 
   virtual bool OnMouseDragged(const ui::MouseEvent& event) OVERRIDE {
+    // Do not change or select text by right button drag.
+    if (event.IsOnlyRightMouseButton())
+      return true;
     bool result = views::Textfield::OnMouseDragged(event);
     omnibox_view_->HandleMouseDragEvent(event);
     return result;
   }
 
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE {
     views::Textfield::OnMouseReleased(event);

[sky, 2012/09/24 14:03:02]

Do things get confused without forwarding the release?

[simonhong_, 2012/09/24 16:32:21]

You mean context menu also need to disable with dragged right click?
On 2012/09/24 14:03:02, sky wrote:

[sky, 2012/09/24 16:48:09]

No, I just wasn't sure if omnibox_view_ might get confused if it didn't see the
drag. That said, should we be disabling this in views::Textfield and not here?

     omnibox_view_->HandleMouseReleaseEvent(event);
   }
 
  protected:
   // views::View implementation.
   virtual void PaintChildren(gfx::Canvas* canvas) {
     views::Textfield::PaintChildren(canvas);
     MaybeDrawPlaceholderText(canvas);
   }
 
@@ skipping 801 matching lines @@
 
 string16 OmniboxViewViews::GetSelectedText() const {
   // TODO(oshima): Support instant, IME.
   return textfield_->GetSelectedText();
 }
 
 void OmniboxViewViews::CopyURL() {
   const string16& text = toolbar_model()->GetText(false);
   DoCopy(text, true, toolbar_model()->GetURL(), text);
 }