Issue 10968047: cc_unittests fails on several platforms with 158148

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10968047: cc_unittests fails on several platforms with 158148 (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
8 years, 2 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

cc_unittests fails on several platforms with 158148 Revert 158148 - [cc] Color evicted vs. invalidated checkerboard tiles differently If --show-debug-layer-borders are on, tint checkerboards differently. * Light red = texture backing for tile was evicted or never painted * Light blue = we have a texture backing, but it's been invalidated BUG=150610 Review URL: https://chromiumcodereview.appspot.com/10962042 TBR=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158169

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -67 lines)			Patch
M	cc/CCCheckerboardDrawQuad.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	cc/CCCheckerboardDrawQuad.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	cc/CCDrawQuadTest.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	cc/CCRenderPassTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/CCRendererGL.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	cc/CCTiledLayerImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/CCTiledLayerImpl.cpp	View	3 chunks	+3 lines, -32 lines	0 comments	Download
M	cc/ShaderChromium.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cc/ShaderChromium.cpp	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	cc/TiledLayerChromium.cpp	View	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

No link to broken build results? Which platforms failed?

8 years, 3 months ago (2012-09-24 15:34:39 UTC) #2

Vitaly Buka (NO REVIEWS)

8 years, 2 months ago (2012-09-25 09:48:24 UTC) #3

On 2012/09/24 15:34:39, enne wrote:
> No link to broken build results?  Which platforms failed?

http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages