Issue 10968036: [net/dns] Extend async DNS field trial to other supported platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10968036: [net/dns] Extend async DNS field trial to other supported platforms. (Closed)

Created:
8 years, 3 months ago by szym

Modified:
8 years, 3 months ago

Reviewers:
cbentzel

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[net/dns] Extend async DNS field trial to other supported platforms. BUG=143454 ' will be ignored, and an empty message aborts the commit. R=cbentzel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158024

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/net/async_dns_field_trial.cc	View		1 chunk	+0 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cbentzel

LGTM http://codereview.chromium.org/10968036/diff/1/chrome/browser/net/async_dns_field_trial.cc File chrome/browser/net/async_dns_field_trial.cc (left): http://codereview.chromium.org/10968036/diff/1/chrome/browser/net/async_dns_field_trial.cc#oldcode14 chrome/browser/net/async_dns_field_trial.cc:14: #if defined(OS_ANDROID) || defined(OS_IOS) For another CL - ...

8 years, 3 months ago (2012-09-21 17:05:39 UTC) #2

szym

http://codereview.chromium.org/10968036/diff/1/chrome/browser/net/async_dns_field_trial.cc File chrome/browser/net/async_dns_field_trial.cc (left): http://codereview.chromium.org/10968036/diff/1/chrome/browser/net/async_dns_field_trial.cc#oldcode14 chrome/browser/net/async_dns_field_trial.cc:14: #if defined(OS_ANDROID) || defined(OS_IOS) On 2012/09/21 17:05:39, cbentzel wrote: ...

8 years, 3 months ago (2012-09-21 18:11:12 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-09-21 18:11:12 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/10968036/1

Expand Messages | Collapse Messages