Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 10968015: Revert 157773 - This is followup from Charlie's comments on Fady's cl: http://chromiumcodereview.ap… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
===================================================================
--- content/renderer/browser_plugin/browser_plugin_browsertest.cc (revision 157800)
+++ content/renderer/browser_plugin/browser_plugin_browsertest.cc (working copy)
@@ -30,7 +30,7 @@
content::kBrowserPluginNewMimeType);
}
-} // namespace
+}
namespace content {
@@ -114,43 +114,39 @@
{
const IPC::Message* msg =
browser_plugin_manager()->sink().GetUniqueMessageMatching(
- BrowserPluginHostMsg_NavigateGuest::ID);
+ BrowserPluginHostMsg_NavigateOrCreateGuest::ID);
ASSERT_TRUE(msg);
int instance_id;
long long frame_id;
std::string src;
- gfx::Size size;
- BrowserPluginHostMsg_NavigateGuest::Read(
+ BrowserPluginHostMsg_NavigateOrCreateGuest::Read(
msg,
&instance_id,
&frame_id,
- &src,
- &size);
+ &src);
EXPECT_EQ("foo", src);
}
browser_plugin_manager()->sink().ClearMessages();
// Navigate to bar and observe the associated
- // BrowserPluginHostMsg_NavigateGuest message.
+ // BrowserPluginHostMsg_NavigateOrCreateGuest message.
// Verify that the src attribute is updated as well.
ExecuteJavaScript("document.getElementById('browserplugin').src = 'bar'");
{
const IPC::Message* msg =
browser_plugin_manager()->sink().GetUniqueMessageMatching(
- BrowserPluginHostMsg_NavigateGuest::ID);
+ BrowserPluginHostMsg_NavigateOrCreateGuest::ID);
ASSERT_TRUE(msg);
int instance_id;
long long frame_id;
std::string src;
- gfx::Size size;
- BrowserPluginHostMsg_NavigateGuest::Read(
+ BrowserPluginHostMsg_NavigateOrCreateGuest::Read(
msg,
&instance_id,
&frame_id,
- &src,
- &size);
+ &src);
EXPECT_EQ("bar", src);
std::string src_value =
ExecuteScriptAndReturnString(
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/browser_plugin/browser_plugin_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698