Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 10968015: Revert 157773 - This is followup from Charlie's comments on Fady's cl: http://chromiumcodereview.ap… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_view_host_impl.cc (revision 157800)
+++ content/browser/renderer_host/render_view_host_impl.cc (working copy)
@@ -29,7 +29,6 @@
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/common/accessibility_messages.h"
-#include "content/common/browser_plugin_messages.h"
#include "content/common/content_constants_internal.h"
#include "content/common/desktop_notification_messages.h"
#include "content/common/drag_messages.h"
@@ -834,17 +833,7 @@
// RenderViewHostImpl, IPC message handlers:
bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
- // Allow BrowserPluginHostMsg_* sync messages to run on the UI thread.
- // Platform apps will not support windowed plugins so the deadlock cycle
- // browser -> plugin -> renderer -> browser referred in
- // BrowserMessageFilter::CheckCanDispatchOnUI() is not supposed to happen. If
- // we want to support windowed plugins, sync messages in BrowserPlugin might
- // need to be changed to async messages.
- // TODO(fsamuel): Disallow BrowserPluginHostMsg_* sync messages to run on UI
- // thread and make these messages async: http://crbug.com/149063.
- if (msg.type() != BrowserPluginHostMsg_HandleInputEvent::ID &&
- msg.type() != BrowserPluginHostMsg_ResizeGuest::ID &&
- !BrowserMessageFilter::CheckCanDispatchOnUI(msg, this))
+ if (!BrowserMessageFilter::CheckCanDispatchOnUI(msg, this))
return true;
// Filter out most IPC messages if this renderer is swapped out.
« no previous file with comments | « content/browser/browser_plugin/test_browser_plugin_guest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698