DescriptionMerge 157777 - Speech Input: always abort when user clicks outside speech bubble.
This prevents a race which would lead to a browser crash (null ptr deref) when
a speech input icon is clicked on repeatedly:
1. User clicks speech icon
2. We show speech bubble, ask sound system to start recording
3. User clicks outside bubble, we close it
3a. Speech system not recording yet, so we don't abort session
4. Sound system calls back: "Here's some audio!"
5. We try to update the bubble which dosn't exist anymore.
This patch fixes 3a; we should just always abort here.
BUG=146689
TEST=manual (click speech icon rapidly many times)
Review URL: https://chromiumcodereview.appspot.com/10960010
TBR=hans@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157778
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|