Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 10968014: Merge 157777 - Speech Input: always abort when user clicks outside speech bubble. (Closed)

Created:
8 years, 3 months ago by hans
Modified:
8 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, Satish
Visibility:
Public.

Description

Merge 157777 - Speech Input: always abort when user clicks outside speech bubble. This prevents a race which would lead to a browser crash (null ptr deref) when a speech input icon is clicked on repeatedly: 1. User clicks speech icon 2. We show speech bubble, ask sound system to start recording 3. User clicks outside bubble, we close it 3a. Speech system not recording yet, so we don't abort session 4. Sound system calls back: "Here's some audio!" 5. We try to update the bubble which dosn't exist anymore. This patch fixes 3a; we should just always abort here. BUG=146689 TEST=manual (click speech icon rapidly many times) Review URL: https://chromiumcodereview.appspot.com/10960010 TBR=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
hans
8 years, 3 months ago (2012-09-20 16:14:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698