Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1096793003: Make test apks exclude dex files in tested apk (Closed)

Created:
5 years, 8 months ago by cjhopman
Modified:
5 years, 8 months ago
Reviewers:
Yaron, newt (away)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make test apks exclude dex files in tested apk This adds the apk_under_test variable to the android_apk template. When this is set, we will build the apk as though it is an instrumentation test for the apk set in apk_under_test. When building an instrumentation test apk, the dex file should not contain libraries that are already included in the apk_under_test (the dex files from both apks are loaded into the classloader when running tests). The dex files to be included are calculating in write_build_config.py. BUG=359249 Committed: https://crrev.com/7b9ba2e6b4f149845360a6e0f3fa4b0ac459e6be Cr-Commit-Position: refs/heads/master@{#326398}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M build/android/gyp/write_build_config.py View 2 chunks +19 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +15 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 3 chunks +7 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
cjhopman
newt: *
5 years, 8 months ago (2015-04-17 19:12:37 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-17 21:19:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096793003/1
5 years, 8 months ago (2015-04-17 22:57:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57304)
5 years, 8 months ago (2015-04-18 00:25:48 UTC) #7
cjhopman
yfriedman: content/shell/android/
5 years, 8 months ago (2015-04-21 17:55:49 UTC) #9
Yaron
On 2015/04/21 17:55:49, cjhopman wrote: > yfriedman: content/shell/android/ that lgtm but what about chrome_shell and ...
5 years, 8 months ago (2015-04-21 20:27:12 UTC) #10
cjhopman
On 2015/04/21 20:27:12, Yaron wrote: > On 2015/04/21 17:55:49, cjhopman wrote: > > yfriedman: content/shell/android/ ...
5 years, 8 months ago (2015-04-22 19:16:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096793003/20001
5 years, 8 months ago (2015-04-22 19:18:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-22 23:32:00 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:32:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b9ba2e6b4f149845360a6e0f3fa4b0ac459e6be
Cr-Commit-Position: refs/heads/master@{#326398}

Powered by Google App Engine
This is Rietveld 408576698