Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1096783002: Re-apply remoting webapp html in gn (Closed)

Created:
5 years, 8 months ago by garykac
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Enable remoting webapp main.html GN build. This is a re-land of crrev.com/1082083005 The previous remoting webapp GN build files were not enabled and at least 6 months out of date. This cl fixes the problem by bringing the build rules up to date and enables the webapp build. It also starts to move all the remoting-specific build rules into the remoting dir rather than having them in the main build.gn file. BUG= Committed: https://crrev.com/3eddb5b20af3eb8ae4393ad64fccfd4d69127679 Cr-Commit-Position: refs/heads/master@{#325733}

Patch Set 1 : Original cl #

Patch Set 2 : Add missing .gni files. #

Patch Set 3 : Remove ref to remoting.js (deleted) #

Patch Set 4 : Disable host on win/mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -191 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -13 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -11 lines 0 comments Download
M remoting/BUILD.gn View 2 chunks +58 lines, -1 line 0 comments Download
M remoting/remoting_all.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
A remoting/remoting_enable.gni View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M remoting/remoting_enable.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/BUILD.gn View 2 chunks +15 lines, -166 lines 0 comments Download
A remoting/webapp/files.gni View 1 2 1 chunk +481 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
garykac
This fixes the host build on mac/win (by disabling it). Manually lauched the Mac/Win GN ...
5 years, 8 months ago (2015-04-17 18:52:07 UTC) #2
garykac
On 2015/04/17 18:52:07, garykac wrote: > This fixes the host build on mac/win (by disabling ...
5 years, 8 months ago (2015-04-17 21:06:57 UTC) #3
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-17 21:29:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096783002/60001
5 years, 8 months ago (2015-04-17 22:14:28 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-17 23:16:46 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 23:18:08 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3eddb5b20af3eb8ae4393ad64fccfd4d69127679
Cr-Commit-Position: refs/heads/master@{#325733}

Powered by Google App Engine
This is Rietveld 408576698