Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3694)

Unified Diff: chrome/browser/about_flags.cc

Issue 1096773002: Switching Clank to use direction-based selection granularity strategy and adding a chrome flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unified_ALL_unchanged
Patch Set: Adding the new flag to LoginCustomFlags enum Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 48d8576df52e2bada55ba35d105fac803873b2d6..ce2f5975f92bf29c10ae133c19f3c3c576d13e16 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -178,6 +178,16 @@ const Experiment::Choice kOverscrollHistoryNavigationChoices[] = {
};
#endif
+const Experiment::Choice kTouchTextSelectionStrategyChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_TOUCH_SELECTION_STRATEGY_CHARACTER,
+ switches::kTouchTextSelectionStrategy,
+ "character" },
+ { IDS_TOUCH_SELECTION_STRATEGY_DIRECTION,
+ switches::kTouchTextSelectionStrategy,
+ "direction" }
+};
+
#if !defined(DISABLE_NACL)
const Experiment::Choice kNaClDebugMaskChoices[] = {
// Secure shell can be used on ChromeOS for forwarding the TCP port opened by
@@ -1200,6 +1210,13 @@ const Experiment kExperiments[] = {
switches::kDisableTouchEditing)
},
{
+ "touch-selection-strategy",
+ IDS_FLAGS_TOUCH_SELECTION_STRATEGY_NAME,
+ IDS_FLAGS_TOUCH_SELECTION_STRATEGY_DESCRIPTION,
+ kOsAndroid, // TODO(mfomitchev): Add CrOS/Win/Linux support soon.
+ MULTI_VALUE_TYPE(kTouchTextSelectionStrategyChoices)
+ },
+ {
"enable-stale-while-revalidate",
IDS_FLAGS_ENABLE_STALE_WHILE_REVALIDATE_NAME,
IDS_FLAGS_ENABLE_STALE_WHILE_REVALIDATE_DESCRIPTION,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698