Switching Clank to use direction-based selection granularity strategy and adding a chrome flag.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 743 matching lines @@
     webview()->setMainFrame(main_render_frame_->GetWebFrame());
   }
   main_render_frame_->Initialize();
 
   if (switches::IsTouchDragDropEnabled())
     webview()->settings()->setTouchDragDropEnabled(true);
 
   if (switches::IsTouchEditingEnabled())
     webview()->settings()->setTouchEditingEnabled(true);
 
+#if defined(OS_ANDROID)
+  WebSettings::SelectionStrategyType selection_strategy_default =
+      WebSettings::StrategyDirection;
+#else
+  WebSettings::SelectionStrategyType selection_strategy_default =
+      WebSettings::StrategyCharacter;
+#endif
+
+  WebSettings::SelectionStrategyType selection_strategy =
+      selection_strategy_default;
+  const std::string selection_strategy_str =
+      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kTouchTextSelectionStrategy);
+  if (selection_strategy_str == "0")

[Charlie Reis, 2015/04/22 19:04:59]

From the earlier discussion, I think "character" or "direction" do seem like
better values than the strings "0" or "1".  That's more sensible to pass in from
the command line, and it makes this easier to read.

[mfomitchev, 2015/04/22 21:17:24]

Done.

+    selection_strategy = WebSettings::StrategyCharacter;
+  else if (selection_strategy_str == "1")
+    selection_strategy = WebSettings::StrategyDirection;
+  webview()->settings()->setSelectionStrategy(selection_strategy);
+
   if (!params.frame_name.empty())
     webview()->mainFrame()->setName(params.frame_name);
 
   // TODO(davidben): Move this state from Blink into content.
   if (params.window_was_created_with_opener)
     webview()->setOpenedByDOM();
 
   OnSetRendererPrefs(params.renderer_preferences);
 
   ApplyBlinkSettings(command_line, webview()->settings());
@@ skipping 2995 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content