Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1096763003: Small polishing changes to the native js. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Small polishing changes to the native js. R=jkummerow@chromium.org Committed: https://crrev.com/42415bf9bc5aa7266267e731140e5beed6909796 Cr-Commit-Position: refs/heads/master@{#27949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M src/i18n.js View 6 chunks +9 lines, -7 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/proxy.js View 3 chunks +3 lines, -2 lines 0 comments Download
M src/runtime.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 8 months ago (2015-04-20 13:56:00 UTC) #1
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-20 15:21:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096763003/1
5 years, 8 months ago (2015-04-20 18:18:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 19:19:01 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42415bf9bc5aa7266267e731140e5beed6909796 Cr-Commit-Position: refs/heads/master@{#27949}
5 years, 8 months ago (2015-04-20 19:19:14 UTC) #6
dusmil.imgtec
5 years, 8 months ago (2015-04-21 12:23:30 UTC) #7
Message was sent while issue was closed.
The removal of GetRootNan() causes problems for MIPS. The mips have different
qNan encoding.

We rely on GetRootNan() so the NaNs dumped in snapshot are unified and come from
the same source which is global nan.
Doing so we can change Nan to be consistent to MIPS spec during deserialization
by patching global nan.

See line isolate.cc:2167

  // Quiet the heap NaN if needed on target platform.
  if (!create_heap_objects) Assembler::QuietNaN(heap_.nan_value());


The 0/0 expression will create x86 NaNs (wrong values for mips) during snapshot
creation of builtins on host which are scattered and placed in snapshot
so they cannot longer be fixed during bootstrap.

Powered by Google App Engine
This is Rietveld 408576698