Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1096753002: Small change to allow DistanceField and BMP text to coexist in a blob (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atdfnow
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Small change to allow DistanceField and BMP text to coexist in a blob BUG=skia: Committed: https://skia.googlesource.com/skia/+/fec19e1751d1a20748e9beaf0a948c01ffe89f04

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : cleanup #

Patch Set 4 : whoops #

Total comments: 1

Patch Set 5 : adding a comment #

Patch Set 6 : warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -26 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 3 4 4 chunks +27 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 5 6 chunks +17 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
PTAL
5 years, 8 months ago (2015-04-17 16:04:44 UTC) #2
jvanverth1
lgtm + comment https://codereview.chromium.org/1096753002/diff/60001/src/gpu/GrAtlasTextContext.h File src/gpu/GrAtlasTextContext.h (right): https://codereview.chromium.org/1096753002/diff/60001/src/gpu/GrAtlasTextContext.h#newcode121 src/gpu/GrAtlasTextContext.h:121: SkAutoTDelete<SkAutoDescriptor> fOverrideDescriptor; A suggestion to investigate ...
5 years, 8 months ago (2015-04-17 17:07:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096753002/80001
5 years, 8 months ago (2015-04-17 17:16:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/548)
5 years, 8 months ago (2015-04-17 17:18:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096753002/100001
5 years, 8 months ago (2015-04-17 17:22:45 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 17:32:37 UTC) #12
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/fec19e1751d1a20748e9beaf0a948c01ffe89f04

Powered by Google App Engine
This is Rietveld 408576698