Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 66614ca8fdff59c6b640885f226aaf30f7760700..d11334e17fc7e9d0f43de25173a6fc166a896256 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -154,8 +154,8 @@ void ProcessOnOsUpgradeWorkItems(
const installer::Product& product) {
scoped_ptr<WorkItemList> work_item_list(
WorkItem::CreateNoRollbackWorkItemList());
- AddOsUpgradeWorkItems(installer_state, base::FilePath(), base::Version(),
- product, work_item_list.get());
+ AddOsUpgradeWorkItems(installer_state, base::FilePath(), Version(), product,
+ work_item_list.get());
if (!work_item_list->Do())
LOG(ERROR) << "Failed to remove on-os-upgrade command.";
}
@@ -521,9 +521,8 @@ DeleteResult DeleteChromeDirectoriesIfEmpty(
return result;
}
-DeleteResult DeleteAppHostFilesAndFolders(
- const InstallerState& installer_state,
- const base::Version& installed_version) {
+DeleteResult DeleteAppHostFilesAndFolders(const InstallerState& installer_state,
+ const Version& installed_version) {
const base::FilePath& target_path = installer_state.target_path();
if (target_path.empty()) {
LOG(ERROR) << "DeleteAppHostFilesAndFolders: no installation destination "
@@ -917,8 +916,8 @@ const wchar_t kChromeExtProgId[] = L"ChromiumExt";
bool ProcessDelegateExecuteWorkItems(const InstallerState& installer_state,
const Product& product) {
scoped_ptr<WorkItemList> item_list(WorkItem::CreateNoRollbackWorkItemList());
- AddDelegateExecuteWorkItems(installer_state, base::FilePath(),
- base::Version(), product, item_list.get());
+ AddDelegateExecuteWorkItems(installer_state, base::FilePath(), Version(),
+ product, item_list.get());
return item_list->Do();
}
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698