chrome/common/service_process_util.cc - Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util.cc

diff --git a/chrome/common/service_process_util.cc b/chrome/common/service_process_util.cc

index 6773fabc32df1f33126c0e54459cd0e50d7ce7cb..d542b74e368cb2553c6ab2cb5ed8cc1a2231ed61 100644

--- a/chrome/common/service_process_util.cc

+++ b/chrome/common/service_process_util.cc

@@ -67,7 +67,7 @@ ServiceProcessRunningState GetServiceProcessRunningState(

if (service_version_out)

*service_version_out = version;

- base::Version service_version(version);

+ Version service_version(version);

// If the version string is invalid, treat it like an older version.

if (!service_version.IsValid())

return SERVICE_OLDER_VERSION_RUNNING;

@@ -80,7 +80,7 @@ ServiceProcessRunningState GetServiceProcessRunningState(

// are out of date.

return SERVICE_NEWER_VERSION_RUNNING;

}

- base::Version running_version(version_info.Version());

+ Version running_version(version_info.Version());

if (!running_version.IsValid()) {

NOTREACHED() << "Failed to parse version info";

// Our own version is invalid. This is an error case. Pretend that we

« no previous file with comments | « chrome/common/extensions/update_manifest.cc ('k') | chrome/common/service_process_util_mac.mm » ('j') | no next file with comments »