Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_paths.cc ('k') | chrome/common/extensions/update_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
diff --git a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
index 8f63db6fb744374c57c37b83f73d5c6827cab87f..d675d3e1543bfd8ac96f2ea8eb949788f793221e 100644
--- a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
+++ b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
@@ -33,14 +33,14 @@ bool MinimumChromeVersionChecker::Parse(Extension* extension,
return false;
}
- base::Version minimum_version(minimum_version_string);
+ Version minimum_version(minimum_version_string);
if (!minimum_version.IsValid()) {
*error = base::ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);
return false;
}
chrome::VersionInfo current_version_info;
- base::Version current_version(current_version_info.Version());
+ Version current_version(current_version_info.Version());
if (!current_version.IsValid()) {
NOTREACHED();
return false;
« no previous file with comments | « chrome/common/chrome_paths.cc ('k') | chrome/common/extensions/update_manifest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698