Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6618)

Unified Diff: chrome/browser/ui/webui/help/version_updater_win.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/version_updater_win.cc
diff --git a/chrome/browser/ui/webui/help/version_updater_win.cc b/chrome/browser/ui/webui/help/version_updater_win.cc
index 1db095a41b357234da67f4e8cf08049ba78c9c75..9491e102b62583f826d248efb2126bf1fca9e449 100644
--- a/chrome/browser/ui/webui/help/version_updater_win.cc
+++ b/chrome/browser/ui/webui/help/version_updater_win.cc
@@ -57,7 +57,7 @@ class VersionUpdaterWin : public VersionUpdater,
// Got the intalled version so the handling of the UPGRADE_ALREADY_UP_TO_DATE
// result case can now be completeb on the UI thread.
- void GotInstalledVersion(const base::Version& version);
+ void GotInstalledVersion(const Version& version);
// Little helper function to create google_updater_.
void CreateGoogleUpdater();
@@ -119,7 +119,7 @@ class VersionReader
// This is the version that gets read in the FILE thread and set on the
// the updater in the UI thread.
- base::Version installed_version_;
+ Version installed_version_;
};
VersionUpdaterWin::VersionUpdaterWin()
@@ -241,7 +241,7 @@ void VersionUpdaterWin::UpdateStatus(GoogleUpdateUpgradeResult result,
#endif // defined(GOOGLE_CHROME_BUILD)
}
-void VersionUpdaterWin::GotInstalledVersion(const base::Version& version) {
+void VersionUpdaterWin::GotInstalledVersion(const Version& version) {
// This must be called on the UI thread so that callback_ can be called.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -252,7 +252,7 @@ void VersionUpdaterWin::GotInstalledVersion(const base::Version& version) {
// may be already up to date on disk though the running app is still
// out of date.
chrome::VersionInfo version_info;
- base::Version running_version(version_info.Version());
+ Version running_version(version_info.Version());
if (!version.IsValid() || version.CompareTo(running_version) <= 0) {
content::RecordAction(
UserMetricsAction("UpgradeCheck_AlreadyUpToDate"));
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698