chrome/browser/first_run/upgrade_util_win.cc - Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/upgrade_util_win.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/first_run/upgrade_util_win.cc

diff --git a/chrome/browser/first_run/upgrade_util_win.cc b/chrome/browser/first_run/upgrade_util_win.cc

index 3c430fd91c888cb51f66c2fb22b7289f744453c1..47d74653518ee033bce5d7cab2b5e798028d7a7d 100644

--- a/chrome/browser/first_run/upgrade_util_win.cc

+++ b/chrome/browser/first_run/upgrade_util_win.cc

@@ -235,12 +235,12 @@ bool SwapNewChromeExeIfPresent() {

if (cmd_line.HasSwitch(switches::kChromeVersion)) {

std::string version_string =

cmd_line.GetSwitchValueASCII(switches::kChromeVersion);

- base::Version cmd_version(version_string);

+ Version cmd_version(version_string);

std::wstring pv_value;

if (key.ReadValue(google_update::kRegVersionField,

&pv_value) == ERROR_SUCCESS) {

- base::Version pv_version(WideToASCII(pv_value));

+ Version pv_version(WideToASCII(pv_value));

if (cmd_version.IsValid() && pv_version.IsValid() &&

!cmd_version.Equals(pv_version)) {

return false;

« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/hang_monitor/hung_plugin_action.cc » ('j') | no next file with comments »