Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5017)

Unified Diff: chrome/browser/extensions/api/runtime/runtime_api.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/runtime/runtime_api.cc
diff --git a/chrome/browser/extensions/api/runtime/runtime_api.cc b/chrome/browser/extensions/api/runtime/runtime_api.cc
index 95cc8ee67652db87f78f1a18f425821bc9e18cd0..03ce5ce9553dbb356d43fc8b60ae3911ac8733cb 100644
--- a/chrome/browser/extensions/api/runtime/runtime_api.cc
+++ b/chrome/browser/extensions/api/runtime/runtime_api.cc
@@ -215,7 +215,7 @@ void RuntimeAPI::OnExtensionLoaded(const Extension* extension) {
base::Bind(&RuntimeEventRouter::DispatchOnInstalledEvent,
browser_context_,
extension->id(),
- base::Version(),
+ Version(),
true));
}
@@ -224,7 +224,7 @@ void RuntimeAPI::OnExtensionInstalled(const Extension* extension) {
ExtensionService* service = ExtensionSystem::GetForBrowserContext(
browser_context_)->extension_service();
const Extension* old = service->GetExtensionById(extension->id(), true);
- base::Version old_version;
+ Version old_version;
if (old)
old_version = *old->version();
@@ -269,7 +269,7 @@ void RuntimeEventRouter::DispatchOnStartupEvent(
void RuntimeEventRouter::DispatchOnInstalledEvent(
content::BrowserContext* context,
const std::string& extension_id,
- const base::Version& old_version,
+ const Version& old_version,
bool chrome_updated) {
if (!ExtensionsBrowserClient::Get()->IsValidContext(context))
return;
@@ -477,10 +477,9 @@ void RuntimeRequestUpdateCheckFunction::Observe(
return;
DCHECK(type == chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND);
- typedef const std::pair<std::string, base::Version> UpdateDetails;
+ typedef const std::pair<std::string, Version> UpdateDetails;
const std::string& id = content::Details<UpdateDetails>(details)->first;
- const base::Version& version =
- content::Details<UpdateDetails>(details)->second;
+ const Version& version = content::Details<UpdateDetails>(details)->second;
if (id == extension_id()) {
ReplyUpdateFound(version.GetString());
}
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698