Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines specific implementation of BrowserDistribution class for 5 // This file defines specific implementation of BrowserDistribution class for
6 // Google Chrome. 6 // Google Chrome.
7 7
8 #include "chrome/installer/util/google_chrome_distribution.h" 8 #include "chrome/installer/util/google_chrome_distribution.h"
9 9
10 #include <windows.h> 10 #include <windows.h>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 } 60 }
61 61
62 } // namespace 62 } // namespace
63 63
64 GoogleChromeDistribution::GoogleChromeDistribution() 64 GoogleChromeDistribution::GoogleChromeDistribution()
65 : BrowserDistribution(CHROME_BROWSER), 65 : BrowserDistribution(CHROME_BROWSER),
66 product_guid_(kChromeGuid) { 66 product_guid_(kChromeGuid) {
67 } 67 }
68 68
69 void GoogleChromeDistribution::DoPostUninstallOperations( 69 void GoogleChromeDistribution::DoPostUninstallOperations(
70 const base::Version& version, 70 const Version& version,
71 const base::FilePath& local_data_path, 71 const base::FilePath& local_data_path,
72 const base::string16& distribution_data) { 72 const base::string16& distribution_data) {
73 // Send the Chrome version and OS version as params to the form. 73 // Send the Chrome version and OS version as params to the form.
74 // It would be nice to send the locale, too, but I don't see an 74 // It would be nice to send the locale, too, but I don't see an
75 // easy way to get that in the existing code. It's something we 75 // easy way to get that in the existing code. It's something we
76 // can add later, if needed. 76 // can add later, if needed.
77 // We depend on installed_version.GetString() not having spaces or other 77 // We depend on installed_version.GetString() not having spaces or other
78 // characters that need escaping: 0.2.13.4. Should that change, we will 78 // characters that need escaping: 0.2.13.4. Should that change, we will
79 // need to escape the string before using it in a URL. 79 // need to escape the string before using it in a URL.
80 const base::string16 kVersionParam = L"crversion"; 80 const base::string16 kVersionParam = L"crversion";
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 product_guid()); 297 product_guid());
298 } 298 }
299 299
300 bool GoogleChromeDistribution::ShouldSetExperimentLabels() { 300 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
301 return true; 301 return true;
302 } 302 }
303 303
304 bool GoogleChromeDistribution::HasUserExperiments() { 304 bool GoogleChromeDistribution::HasUserExperiments() {
305 return true; 305 return true;
306 } 306 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698