Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/app/chrome_breakpad_client.cc

Issue 109673004: Revert "Update all users of base::Version to explicitly specify the namespace, and clean up the hea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_breakpad_client.h" 5 #include "chrome/app/chrome_breakpad_client.h"
6 6
7 #include "base/atomicops.h" 7 #include "base/atomicops.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 scoped_ptr<base::Environment> env(base::Environment::Create()); 164 scoped_ptr<base::Environment> env(base::Environment::Create());
165 if (!env->HasVar(env_vars::kRestartInfo)) 165 if (!env->HasVar(env_vars::kRestartInfo))
166 return false; 166 return false;
167 167
168 env->SetVar(env_vars::kShowRestart, "1"); 168 env->SetVar(env_vars::kShowRestart, "1");
169 return true; 169 return true;
170 } 170 }
171 171
172 bool ChromeBreakpadClient::GetDeferredUploadsSupported( 172 bool ChromeBreakpadClient::GetDeferredUploadsSupported(
173 bool is_per_user_install) { 173 bool is_per_user_install) {
174 base::Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion( 174 Version update_version = GoogleUpdateSettings::GetGoogleUpdateVersion(
175 !is_per_user_install); 175 !is_per_user_install);
176 if (!update_version.IsValid() || 176 if (!update_version.IsValid() ||
177 update_version.IsOlderThan(std::string(kMinUpdateVersion))) 177 update_version.IsOlderThan(std::string(kMinUpdateVersion)))
178 return false; 178 return false;
179 179
180 return true; 180 return true;
181 } 181 }
182 182
183 bool ChromeBreakpadClient::GetIsPerUserInstall(const base::FilePath& exe_path) { 183 bool ChromeBreakpadClient::GetIsPerUserInstall(const base::FilePath& exe_path) {
184 return InstallUtil::IsPerUserInstall(exe_path.value().c_str()); 184 return InstallUtil::IsPerUserInstall(exe_path.value().c_str());
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 bool ChromeBreakpadClient::EnableBreakpadForProcess( 372 bool ChromeBreakpadClient::EnableBreakpadForProcess(
373 const std::string& process_type) { 373 const std::string& process_type) {
374 return process_type == switches::kRendererProcess || 374 return process_type == switches::kRendererProcess ||
375 process_type == switches::kPluginProcess || 375 process_type == switches::kPluginProcess ||
376 process_type == switches::kPpapiPluginProcess || 376 process_type == switches::kPpapiPluginProcess ||
377 process_type == switches::kZygoteProcess || 377 process_type == switches::kZygoteProcess ||
378 process_type == switches::kGpuProcess; 378 process_type == switches::kGpuProcess;
379 } 379 }
380 380
381 } // namespace chrome 381 } // namespace chrome
OLDNEW
« no previous file with comments | « base/version_unittest.cc ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698