Issue 10967064: Split test/mjsunit/math-floor into smaller chunks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967064: Split test/mjsunit/math-floor into smaller chunks (Closed)

Created:
8 years, 3 months ago by Jakob Kummerow

Modified:
8 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split test/mjsunit/math-floor into smaller chunks Committed: https://code.google.com/p/v8/source/detail?r=12588

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -345 lines)			Patch
D	test/mjsunit/math-floor.js	View	1 chunk	+0 lines, -159 lines	0 comments	Download
A +	test/mjsunit/math-floor-part1.js	View	2 chunks	+1 line, -72 lines	0 comments	Download
A +	test/mjsunit/math-floor-part2.js	View	1 chunk	+42 lines, -16 lines	0 comments	Download
A +	test/mjsunit/math-floor-part3.js	View	2 chunks	+1 line, -82 lines	0 comments	Download
A +	test/mjsunit/math-floor-part4.js	View	1 chunk	+42 lines, -16 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. No lines were actually added or removed. I had to duplicate the tests' header ...

8 years, 3 months ago (2012-09-24 08:58:51 UTC) #1

Yang

LGTM with suggestion. http://codereview.chromium.org/10967064/diff/1/test/mjsunit/math-floor-part4.js File test/mjsunit/math-floor-part4.js (right): http://codereview.chromium.org/10967064/diff/1/test/mjsunit/math-floor-part4.js#newcode76 test/mjsunit/math-floor-part4.js:76: assertEquals(-0, floorsum(100000, -0)); It seems that ...

8 years, 3 months ago (2012-09-24 09:19:26 UTC) #2

Jakob Kummerow

8 years, 3 months ago (2012-09-24 09:31:21 UTC) #3

http://codereview.chromium.org/10967064/diff/1/test/mjsunit/math-floor-part4.js
File test/mjsunit/math-floor-part4.js (right):

http://codereview.chromium.org/10967064/diff/1/test/mjsunit/math-floor-part4....
test/mjsunit/math-floor-part4.js:76: assertEquals(-0, floorsum(100000, -0));
On 2012/09/24 09:19:26, Yang wrote:
> It seems that this part has been added in r8877 as a regression test. Maybe
you
> want to make this a separate file to make it stand apart?

As discussed offline, let's leave this where it is. It doesn't take long to run,
and we don't have a bug number for it.

Expand Messages | Collapse Messages