cc/layers/io_surface_layer_impl.cc - Issue 1096703006: cc: Some more cleanup and removing TODOs for validating resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/io_surface_layer_impl.cc

Issue 1096703006: cc: Some more cleanup and removing TODOs for validating resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/io_surface_layer_impl.cc

diff --git a/cc/layers/io_surface_layer_impl.cc b/cc/layers/io_surface_layer_impl.cc

index f9acc6832c8399cefa7cf51316ef24dd1f2c0595..a7da986859d5eca6ef391cb55b50cf3efd42c149 100644

--- a/cc/layers/io_surface_layer_impl.cc

+++ b/cc/layers/io_surface_layer_impl.cc

@@ -77,9 +77,6 @@ void IOSurfaceLayerImpl::AppendQuads(

if (visible_quad_rect.IsEmpty())

return;

- // TODO(danakj): crbug.com/455931

- layer_tree_impl()->resource_provider()->ValidateResource(

- io_surface_resource_id_);

IOSurfaceDrawQuad* quad =

render_pass->CreateAndAppendDrawQuad<IOSurfaceDrawQuad>();

quad->SetNew(shared_quad_state,

@@ -89,6 +86,7 @@ void IOSurfaceLayerImpl::AppendQuads(

io_surface_size_,

io_surface_resource_id_,

IOSurfaceDrawQuad::FLIPPED);

+ ValidateQuadResources(quad);

}

void IOSurfaceLayerImpl::ReleaseResources() {

« no previous file with comments | « cc/layers/heads_up_display_layer_impl.cc ('k') | cc/layers/layer_impl.h » ('j') | cc/layers/layer_impl.cc » ('J')