Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2249)

Unified Diff: cc/layers/delegated_renderer_layer_impl.cc

Issue 1096703006: cc: Some more cleanup and removing TODOs for validating resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/heads_up_display_layer_impl.cc » ('j') | cc/layers/layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/delegated_renderer_layer_impl.cc
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc
index aa16beb56883d3152baab75fee85c03ecf486284..7037038d356001fce0e817370ececea539f9e7cb 100644
--- a/cc/layers/delegated_renderer_layer_impl.cc
+++ b/cc/layers/delegated_renderer_layer_impl.cc
@@ -408,14 +408,6 @@ void DelegatedRendererLayerImpl::AppendRainbowDebugBorder(
}
}
-// TODO(danakj): crbug.com/455931
-static ResourceProvider::ResourceId ValidateResource(
- ResourceProvider* provider,
- ResourceProvider::ResourceId id) {
- provider->ValidateResource(id);
- return id;
-}
-
void DelegatedRendererLayerImpl::AppendRenderPassQuads(
RenderPass* render_pass,
const RenderPass* delegated_render_pass,
@@ -487,9 +479,7 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
DrawQuad* output_quad = render_pass->CopyFromAndAppendDrawQuad(
delegated_quad, output_shared_quad_state);
output_quad->visible_rect = quad_visible_rect;
- // TODO(danakj): crbug.com/455931
- output_quad->IterateResources(base::Bind(
- &ValidateResource, layer_tree_impl()->resource_provider()));
+ ValidateQuadResources(output_quad);
} else {
RenderPassId delegated_contributing_render_pass_id =
RenderPassDrawQuad::MaterialCast(delegated_quad)->render_pass_id;
@@ -507,9 +497,7 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
RenderPassDrawQuad::MaterialCast(delegated_quad),
output_shared_quad_state, output_contributing_render_pass_id);
output_quad->visible_rect = quad_visible_rect;
- // TODO(danakj): crbug.com/455931
- output_quad->IterateResources(base::Bind(
- &ValidateResource, layer_tree_impl()->resource_provider()));
+ ValidateQuadResources(output_quad);
}
}
}
« no previous file with comments | « no previous file | cc/layers/heads_up_display_layer_impl.cc » ('j') | cc/layers/layer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698