Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: cc/layers/painted_scrollbar_layer_impl.cc

Issue 1096703006: cc: Some more cleanup and removing TODOs for validating resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/painted_scrollbar_layer_impl.h" 5 #include "cc/layers/painted_scrollbar_layer_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "cc/animation/scrollbar_animation_controller.h" 9 #include "cc/animation/scrollbar_animation_controller.h"
10 #include "cc/layers/layer.h" 10 #include "cc/layers/layer.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 visible_thumb_quad_rect, internal_contents_scale_); 96 visible_thumb_quad_rect, internal_contents_scale_);
97 97
98 ResourceProvider::ResourceId thumb_resource_id = 98 ResourceProvider::ResourceId thumb_resource_id =
99 layer_tree_impl()->ResourceIdForUIResource(thumb_ui_resource_id_); 99 layer_tree_impl()->ResourceIdForUIResource(thumb_ui_resource_id_);
100 ResourceProvider::ResourceId track_resource_id = 100 ResourceProvider::ResourceId track_resource_id =
101 layer_tree_impl()->ResourceIdForUIResource(track_ui_resource_id_); 101 layer_tree_impl()->ResourceIdForUIResource(track_ui_resource_id_);
102 102
103 if (thumb_resource_id && !visible_thumb_quad_rect.IsEmpty()) { 103 if (thumb_resource_id && !visible_thumb_quad_rect.IsEmpty()) {
104 gfx::Rect opaque_rect; 104 gfx::Rect opaque_rect;
105 const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; 105 const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f};
106 // TODO(danakj): crbug.com/455931
107 layer_tree_impl()->resource_provider()->ValidateResource(thumb_resource_id);
108 TextureDrawQuad* quad = 106 TextureDrawQuad* quad =
109 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>(); 107 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>();
110 quad->SetNew(shared_quad_state, scaled_thumb_quad_rect, opaque_rect, 108 quad->SetNew(shared_quad_state, scaled_thumb_quad_rect, opaque_rect,
111 scaled_visible_thumb_quad_rect, thumb_resource_id, 109 scaled_visible_thumb_quad_rect, thumb_resource_id,
112 premultipled_alpha, uv_top_left, uv_bottom_right, 110 premultipled_alpha, uv_top_left, uv_bottom_right,
113 SK_ColorTRANSPARENT, opacity, flipped, nearest_neighbor); 111 SK_ColorTRANSPARENT, opacity, flipped, nearest_neighbor);
112 ValidateQuadResources(quad);
114 } 113 }
115 114
116 gfx::Rect track_quad_rect(bounds()); 115 gfx::Rect track_quad_rect(bounds());
117 gfx::Rect scaled_track_quad_rect(internal_content_bounds_); 116 gfx::Rect scaled_track_quad_rect(internal_content_bounds_);
118 gfx::Rect visible_track_quad_rect = 117 gfx::Rect visible_track_quad_rect =
119 draw_properties().occlusion_in_content_space.GetUnoccludedContentRect( 118 draw_properties().occlusion_in_content_space.GetUnoccludedContentRect(
120 track_quad_rect); 119 track_quad_rect);
121 gfx::Rect scaled_visible_track_quad_rect = gfx::ScaleToEnclosingRect( 120 gfx::Rect scaled_visible_track_quad_rect = gfx::ScaleToEnclosingRect(
122 visible_track_quad_rect, internal_contents_scale_); 121 visible_track_quad_rect, internal_contents_scale_);
123 if (track_resource_id && !visible_track_quad_rect.IsEmpty()) { 122 if (track_resource_id && !visible_track_quad_rect.IsEmpty()) {
124 gfx::Rect opaque_rect(contents_opaque() ? scaled_track_quad_rect 123 gfx::Rect opaque_rect(contents_opaque() ? scaled_track_quad_rect
125 : gfx::Rect()); 124 : gfx::Rect());
126 const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; 125 const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f};
127 // TODO(danakj): crbug.com/455931
128 layer_tree_impl()->resource_provider()->ValidateResource(track_resource_id);
129 TextureDrawQuad* quad = 126 TextureDrawQuad* quad =
130 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>(); 127 render_pass->CreateAndAppendDrawQuad<TextureDrawQuad>();
131 quad->SetNew(shared_quad_state, scaled_track_quad_rect, opaque_rect, 128 quad->SetNew(shared_quad_state, scaled_track_quad_rect, opaque_rect,
132 scaled_visible_track_quad_rect, track_resource_id, 129 scaled_visible_track_quad_rect, track_resource_id,
133 premultipled_alpha, uv_top_left, uv_bottom_right, 130 premultipled_alpha, uv_top_left, uv_bottom_right,
134 SK_ColorTRANSPARENT, opacity, flipped, nearest_neighbor); 131 SK_ColorTRANSPARENT, opacity, flipped, nearest_neighbor);
132 ValidateQuadResources(quad);
135 } 133 }
136 } 134 }
137 135
138 gfx::Rect PaintedScrollbarLayerImpl::GetEnclosingRectInTargetSpace() const { 136 gfx::Rect PaintedScrollbarLayerImpl::GetEnclosingRectInTargetSpace() const {
139 return GetScaledEnclosingRectInTargetSpace(internal_contents_scale_); 137 return GetScaledEnclosingRectInTargetSpace(internal_contents_scale_);
140 } 138 }
141 139
142 void PaintedScrollbarLayerImpl::SetThumbThickness(int thumb_thickness) { 140 void PaintedScrollbarLayerImpl::SetThumbThickness(int thumb_thickness) {
143 if (thumb_thickness_ == thumb_thickness) 141 if (thumb_thickness_ == thumb_thickness)
144 return; 142 return;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 183
186 bool PaintedScrollbarLayerImpl::IsThumbResizable() const { 184 bool PaintedScrollbarLayerImpl::IsThumbResizable() const {
187 return false; 185 return false;
188 } 186 }
189 187
190 const char* PaintedScrollbarLayerImpl::LayerTypeAsString() const { 188 const char* PaintedScrollbarLayerImpl::LayerTypeAsString() const {
191 return "cc::PaintedScrollbarLayerImpl"; 189 return "cc::PaintedScrollbarLayerImpl";
192 } 190 }
193 191
194 } // namespace cc 192 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698