Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Side by Side Diff: cc/layers/layer_impl.h

Issue 1096703006: cc: Some more cleanup and removing TODOs for validating resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_LAYER_IMPL_H_ 5 #ifndef CC_LAYERS_LAYER_IMPL_H_
6 #define CC_LAYERS_LAYER_IMPL_H_ 6 #define CC_LAYERS_LAYER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 // DidDraw is guaranteed to be called before another WillDraw or before 240 // DidDraw is guaranteed to be called before another WillDraw or before
241 // the layer is destroyed. To enforce this, any class that overrides 241 // the layer is destroyed. To enforce this, any class that overrides
242 // WillDraw/DidDraw must call the base class version only if WillDraw 242 // WillDraw/DidDraw must call the base class version only if WillDraw
243 // returns true. 243 // returns true.
244 virtual bool WillDraw(DrawMode draw_mode, 244 virtual bool WillDraw(DrawMode draw_mode,
245 ResourceProvider* resource_provider); 245 ResourceProvider* resource_provider);
246 virtual void AppendQuads(RenderPass* render_pass, 246 virtual void AppendQuads(RenderPass* render_pass,
247 AppendQuadsData* append_quads_data) {} 247 AppendQuadsData* append_quads_data) {}
248 virtual void DidDraw(ResourceProvider* resource_provider); 248 virtual void DidDraw(ResourceProvider* resource_provider);
249 249
250 // Verify that the resource ids in the quad are valid.
251 void ValidateQuadResources(const DrawQuad* quad) const;
252
250 virtual void GetContentsResourceId(ResourceProvider::ResourceId* resource_id, 253 virtual void GetContentsResourceId(ResourceProvider::ResourceId* resource_id,
251 gfx::Size* resource_size) const; 254 gfx::Size* resource_size) const;
252 255
253 virtual bool HasDelegatedContent() const; 256 virtual bool HasDelegatedContent() const;
254 virtual bool HasContributingDelegatedRenderPasses() const; 257 virtual bool HasContributingDelegatedRenderPasses() const;
255 virtual RenderPassId FirstContributingRenderPassId() const; 258 virtual RenderPassId FirstContributingRenderPassId() const;
256 virtual RenderPassId NextContributingRenderPassId(RenderPassId id) const; 259 virtual RenderPassId NextContributingRenderPassId(RenderPassId id) const;
257 260
258 virtual void NotifyTileStateChanged(const Tile* tile) {} 261 virtual void NotifyTileStateChanged(const Tile* tile) {}
259 262
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 823
821 std::vector<FrameTimingRequest> frame_timing_requests_; 824 std::vector<FrameTimingRequest> frame_timing_requests_;
822 bool frame_timing_requests_dirty_; 825 bool frame_timing_requests_dirty_;
823 826
824 DISALLOW_COPY_AND_ASSIGN(LayerImpl); 827 DISALLOW_COPY_AND_ASSIGN(LayerImpl);
825 }; 828 };
826 829
827 } // namespace cc 830 } // namespace cc
828 831
829 #endif // CC_LAYERS_LAYER_IMPL_H_ 832 #endif // CC_LAYERS_LAYER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698