cc: Some more cleanup and removing TODOs for validating resources.

cc: Some more cleanup and removing TODOs for validating resources.

This adds a LayerImpl::ValidateQuadResources() that each layer can
call on quads that it appends. This function is empty when DCHECKs are
off, which means it should be cheap/free in release builds.

R=piman@chromium.org
BUG=475894
Committed: https://crrev.com/f942757417b8472005abc6ef62dbc18d6d1bf86e
Cr-Commit-Position: refs/heads/master@{#326903}

[danakj, 2015-04-23 22:52:20]

WDYT?

[piman, 2015-04-23 22:55:10]

LGTM, I like this.

https://codereview.chromium.org/1096703006/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1096703006/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:304: void LayerImpl::ValidateQuadResources(const
DrawQuad* quad) const {
nit: do you think we could inline this? That way it become a no-op at the call
site.

https://codereview.chromium.org/1096703006/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1096703006/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:868: CHECK(it != resources_.end());
I wonder if this still triggers now. If not we could probably DCHECK instead.

[danakj, 2015-04-23 22:57:12]

https://codereview.chromium.org/1096703006/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1096703006/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:868: CHECK(it != resources_.end());
On 2015/04/23 22:55:10, piman (Very slow to review) wrote:
> I wonder if this still triggers now. If not we could probably DCHECK instead.

We'll just crash later on *it->second, so ya we could make this DCHECK I guess.

[danakj, 2015-04-23 22:58:07]

https://codereview.chromium.org/1096703006/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1096703006/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:304: void LayerImpl::ValidateQuadResources(const
DrawQuad* quad) const {
On 2015/04/23 22:55:10, piman (Very slow to review) wrote:
> nit: do you think we could inline this? That way it become a no-op at the call
> site.

Ya I can do this. I wanna keep the Bind call in the .cc I think, but I can add
one more function indirection.

[danakj, 2015-04-23 23:01:42]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-23 23:01:43]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1096703006/#ps20001
(title: "cleanup2: inline")

[commit-bot: I haz the power, 2015-04-23 23:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096703006/20001

[piman, 2015-04-23 23:12:53]

awesome. lgtm.

[commit-bot: I haz the power, 2015-04-23 23:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 23:16:07]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-04-24 16:44:12]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-24 16:44:13]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1096703006/#ps40001
(title: "cleanup2: .")

[commit-bot: I haz the power, 2015-04-24 16:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096703006/40001

[commit-bot: I haz the power, 2015-04-24 16:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 16:57:34]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-04-24 20:03:56]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-04-24 20:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1096703006/#ps60001
(title: "cleanup2: const")

[commit-bot: I haz the power, 2015-04-24 20:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096703006/60001

[commit-bot: I haz the power, 2015-04-24 22:19:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-24 22:19:58]

Patchset 4 (id:??) landed as
https://crrev.com/f942757417b8472005abc6ef62dbc18d6d1bf86e
Cr-Commit-Position: refs/heads/master@{#326903}