Issue 10967023: Move unit test init to start of main in window open test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967023: Move unit test init to start of main in window open test. (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move unit test init to start of main in window open test. Committed: https://code.google.com/p/dart/source/detail?r=12663

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	tests/html/window_open_test.dart	View		2 chunks	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 3 months ago (2012-09-21 09:24:22 UTC) #3

https://codereview.chromium.org/10967023/diff/1/tests/html/window_open_test.dart
File tests/html/window_open_test.dart (right):

https://codereview.chromium.org/10967023/diff/1/tests/html/window_open_test.d...
tests/html/window_open_test.dart:13: evaluateJavaScript('(testRunner ||
layoutTestController).setCanOpenWindows()');
I think this will cause an external exception in non-WebKit browsers.

Expand Messages | Collapse Messages