chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moving check_deps exception to specific_include_rules after chat with Kai. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index 924090324a5adfb47b1d4d67d60424a20542139f..a5a2db1a4f7e547cdaee2c38c58e2969f8a59176 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -93,7 +93,10 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

// Open the URL of the given BookmarkNode in the current tab.

- (void)openURLForNode:(const BookmarkNode*)node {

- Browser* browser = browser::FindTabbedBrowser(bridge_->GetProfile(), true);

+ Browser* browser =

+ browser::FindTabbedBrowser(bridge_->GetProfile(),

+ true,

+ chrome::HOST_DESKTOP_TYPE_NATIVE);

if (!browser)

browser = new Browser(Browser::CreateParams(bridge_->GetProfile()));

WindowOpenDisposition disposition =

@@ -112,7 +115,10 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

const BookmarkNode* node = [self nodeForIdentifier:identifier];

DCHECK(node);