chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm - Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

Issue 10967003: Add desktop type context to most existing instances of FindTabbedBrowser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pre-review pass. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_manager/task_manager.cc ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc » ('j') | chrome/browser/ui/webui/options/manage_profile_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

index ca9600d2bcf8c98d024af67e03a71acae16e243d..4a31cb1338d8f18ecce25bf88a81f340137dd208 100644

--- a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

@@ -16,6 +16,7 @@

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_tab_restore_service_delegate.h"

#include "chrome/browser/ui/cocoa/event_utils.h"

+#include "chrome/browser/ui/host_desktop.h"

#include "webkit/glue/window_open_disposition.h"

using content::OpenURLParams;

@@ -38,7 +39,9 @@ using content::Referrer;

// Open the URL of the given history item in the current tab.

- (void)openURLForItem:(const HistoryMenuBridge::HistoryItem*)node {

- Browser* browser = browser::FindOrCreateTabbedBrowser(bridge_->profile());

+ Browser* browser =

+ browser::FindOrCreateTabbedBrowser(bridge_->profile(),

+ chrome::HOST_DESKTOP_TYPE_NATIVE);

WindowOpenDisposition disposition =

event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);