Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1096693011: Don't assert that no incremental marking happened during a non-incremental GC (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't assert that no incremental marking happened during a non-incremental GC If a scavenge is triggered during the GC (via a weak callback or the GC prologue/epilogue), and another mark-compact is triggered (via the same unfortunate code path), we end up doing some incremental steps. BUG=v8:4048 R=dcarney@chromium.org,hpayer@chromium.org LOG=n Committed: https://crrev.com/cc838be4b699c3f2324cc1850876ca8e8ae3a079 Cr-Commit-Position: refs/heads/master@{#27956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/gc-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-21 09:21:37 UTC) #1
dcarney
lgtm
5 years, 8 months ago (2015-04-21 09:28:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096693011/1
5 years, 8 months ago (2015-04-21 09:29:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 10:05:16 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:05:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc838be4b699c3f2324cc1850876ca8e8ae3a079
Cr-Commit-Position: refs/heads/master@{#27956}

Powered by Google App Engine
This is Rietveld 408576698