Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: lib/src/runner/loader.dart

Issue 1096693005: Support @Skip as a suite-level annotation. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 7652165d1eaaaf90c8ecc144f71ed6435928a7e1..764ff5ef33151a1c205c672a7ea285c1802a82d7 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -132,9 +132,10 @@ class Loader {
// Don't load a skipped suite.
if (metadata.skip) {
- return new Future.value(new Suite([
+ controller.add(new Suite([
new LocalTest(path, metadata, () {})
], path: path, platform: platform.name, metadata: metadata));
+ return new Future.value();
kevmoo 2015/04/17 23:56:29 you can just return here – forEach handles null fi
nweiz 2015/04/18 00:07:39 Done. Future.wait makes me paranoid, because it do
}
return new Future.sync(() {

Powered by Google App Engine
This is Rietveld 408576698