Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Issue 109663002: Disables docked windows by default in M33 (Closed)

Created:
7 years ago by varkha
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disables docked windows by default in M33 BUG=None TEST=Visual 1. in chrome://flags verify that ash-disable-docked-windows is absent. 2. in chrome://flags verify that ash-enable-docked-windows is present. 3. When running chrome without ash-enable-docked-windows it should not be possible to dock a window at a screen edge. TEST=ash_unittests --gtest_filter=*Dock* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240475

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M ash/ash_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash_switches.cc View 2 chunks +3 lines, -3 lines 1 comment Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
varkha
sky@, I am planning to land this close to the end of this week and ...
7 years ago (2013-12-09 16:40:09 UTC) #1
sky
LGTM https://codereview.chromium.org/109663002/diff/1/ash/ash_switches.cc File ash/ash_switches.cc (right): https://codereview.chromium.org/109663002/diff/1/ash/ash_switches.cc#newcode97 ash/ash_switches.cc:97: const char kAshEnableDockedWindows[] = "ash-enable-docked-windows"; Move this to ...
7 years ago (2013-12-09 17:03:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/109663002/1
7 years ago (2013-12-12 20:58:51 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-12 23:31:25 UTC) #4
Message was sent while issue was closed.
Change committed as 240475

Powered by Google App Engine
This is Rietveld 408576698