Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 1096623002: Moved guest_view_registry to GuestViewManager and made it an instance map (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch_to_frombrowsercontextifavailable
Patch Set: Addressed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/guest_view.h ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index 287796360b938c4b7c882d82913879849e917e8b..e34288966989fc592e1a9c281ffa0e69ad38d969 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -60,14 +60,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
return nullptr;
}
- using GuestCreationCallback =
- base::Callback<GuestViewBase*(content::WebContents*)>;
- static void RegisterGuestViewType(const std::string& view_type,
- const GuestCreationCallback& callback);
-
- static GuestViewBase* Create(content::WebContents* owner_web_contents,
- const std::string& view_type);
-
static GuestViewBase* FromWebContents(
const content::WebContents* web_contents);
@@ -379,8 +371,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
void StartTrackingEmbedderZoomLevel();
void StopTrackingEmbedderZoomLevel();
- static void RegisterGuestViewTypes();
-
// This guest tracks the lifetime of the WebContents specified by
// |owner_web_contents_|. If |owner_web_contents_| is destroyed then this
// guest will also self-destruct.
« no previous file with comments | « extensions/browser/guest_view/guest_view.h ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698