Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10966025: Change bookmarkManager API from experimental to private. (Closed)

Created:
8 years, 3 months ago by Aaron Boodman
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, tzik+watch_chromium.org, browser-components-watch_chromium.org, dcheng, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, kinuko+watch, Tom Sepez
Visibility:
Public.

Description

Change bookmarkManager API from experimental to private. BUG=37219 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157937

Patch Set 1 #

Patch Set 2 : shrug #

Total comments: 7

Patch Set 3 : bookmarkManager->bookmarkManagerPrivate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -335 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_api_constants.cc View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_helpers.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_helpers.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.h View 1 2 13 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm_test.html View 1 2 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 1 2 11 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/common/extensions/api/bookmark_manager_private.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_bookmark_manager.json View 1 chunk +0 lines, -252 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/file_system/stat View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/file_system/stat_result.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/edit_disabled/manifest.json View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/edit_disabled/test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/standard/manifest.json View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
8 years, 3 months ago (2012-09-21 00:43:03 UTC) #1
Aaron Boodman
+tsepez fyi
8 years, 3 months ago (2012-09-21 00:43:27 UTC) #2
not at google - send to devlin
lgtm assuming s/bookmarkManager/bookmarkManagerPrivate/g is complexity free. https://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/bookmark_manager/js/bmm_test.html File chrome/browser/resources/bookmark_manager/js/bmm_test.html (right): https://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/bookmark_manager/js/bmm_test.html#newcode37 chrome/browser/resources/bookmark_manager/js/bmm_test.html:37: chrome.experimental = chrome.experimental ...
8 years, 3 months ago (2012-09-21 00:55:39 UTC) #3
Tom Sepez
excellent. thanks. https://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/bookmark_manager/js/bmm_test.html File chrome/browser/resources/bookmark_manager/js/bmm_test.html (right): https://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/bookmark_manager/js/bmm_test.html#newcode37 chrome/browser/resources/bookmark_manager/js/bmm_test.html:37: chrome.experimental = chrome.experimental || {}; Still need ...
8 years, 3 months ago (2012-09-21 00:58:16 UTC) #4
Aaron Boodman
8 years, 3 months ago (2012-09-21 01:37:39 UTC) #5 
http://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/book...
File chrome/browser/resources/bookmark_manager/js/bmm_test.html (right):

http://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/book...
chrome/browser/resources/bookmark_manager/js/bmm_test.html:37:
chrome.experimental = chrome.experimental || {};
On 2012/09/21 00:58:16, Tom Sepez wrote:
> Still need this line?

Done.

http://codereview.chromium.org/10966025/diff/28/chrome/browser/resources/book...
chrome/browser/resources/bookmark_manager/js/bmm_test.html:37:
chrome.experimental = chrome.experimental || {};
On 2012/09/21 00:55:40, kalman wrote:
> This should be unnecessary now.

Done.

http://codereview.chromium.org/10966025/diff/28/chrome/common/extensions/api/...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/10966025/diff/28/chrome/common/extensions/api/...
chrome/common/extensions/api/_permission_features.json:38: "bookmarkManager": {
On 2012/09/21 00:55:40, kalman wrote:
> All other component/private APIs are called fooPrivate, so this should be
called
> bookmarkManagerPrivate.

Not all of them, but OK.

Powered by Google App Engine
This is Rietveld 408576698