Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 10966023: Fix the crash that could occur when the window is closed while web contents drag is in progress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch to land Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_mac.mm
diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm
index b5751f2e72ce5feebffd592c32d157056ec2b18f..6d00c181c6a8c12cda18058587c60d471720ca3e 100644
--- a/content/browser/web_contents/web_contents_view_mac.mm
+++ b/content/browser/web_contents/web_contents_view_mac.mm
@@ -250,13 +250,6 @@ void WebContentsViewMac::RestoreFocus() {
focus_tracker_.reset(nil);
}
-bool WebContentsViewMac::IsDoingDrag() const {
- return false;
-}
-
-void WebContentsViewMac::CancelDragAndCloseTab() {
-}
-
WebDropData* WebContentsViewMac::GetDropData() const {
return [cocoa_view_ dropData];
}
@@ -515,6 +508,7 @@ void WebContentsViewMac::CloseTab() {
- (void)clearWebContentsView {
webContentsView_ = NULL;
+ [dragSource_ clearWebContentsView];
}
- (void)closeTabAfterEvent {
« no previous file with comments | « content/browser/web_contents/web_contents_view_mac.h ('k') | content/browser/web_contents/web_contents_view_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698