Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 10966023: Fix the crash that could occur when the window is closed while web contents drag is in progress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch to land Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_android.h" 5 #include "content/browser/web_contents/web_contents_view_android.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/browser/android/content_view_core_impl.h" 8 #include "content/browser/android/content_view_core_impl.h"
9 #include "content/browser/renderer_host/render_widget_host_view_android.h" 9 #include "content/browser/renderer_host/render_widget_host_view_android.h"
10 #include "content/browser/renderer_host/render_view_host_factory.h" 10 #include "content/browser/renderer_host/render_view_host_factory.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 } 123 }
124 124
125 void WebContentsViewAndroid::StoreFocus() { 125 void WebContentsViewAndroid::StoreFocus() {
126 NOTIMPLEMENTED(); 126 NOTIMPLEMENTED();
127 } 127 }
128 128
129 void WebContentsViewAndroid::RestoreFocus() { 129 void WebContentsViewAndroid::RestoreFocus() {
130 NOTIMPLEMENTED(); 130 NOTIMPLEMENTED();
131 } 131 }
132 132
133 bool WebContentsViewAndroid::IsDoingDrag() const {
134 NOTIMPLEMENTED();
135 return false;
136 }
137
138 void WebContentsViewAndroid::CancelDragAndCloseTab() {
139 NOTIMPLEMENTED();
140 }
141
142 WebDropData* WebContentsViewAndroid::GetDropData() const { 133 WebDropData* WebContentsViewAndroid::GetDropData() const {
143 NOTIMPLEMENTED(); 134 NOTIMPLEMENTED();
144 return NULL; 135 return NULL;
145 } 136 }
146 137
147 bool WebContentsViewAndroid::IsEventTracking() const { 138 bool WebContentsViewAndroid::IsEventTracking() const {
148 NOTIMPLEMENTED(); 139 NOTIMPLEMENTED();
149 return false; 140 return false;
150 } 141 }
151 142
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 // This is called when we the renderer asks us to take focus back (i.e., it has 198 // This is called when we the renderer asks us to take focus back (i.e., it has
208 // iterated past the last focusable element on the page). 199 // iterated past the last focusable element on the page).
209 void WebContentsViewAndroid::TakeFocus(bool reverse) { 200 void WebContentsViewAndroid::TakeFocus(bool reverse) {
210 if (web_contents_->GetDelegate() && 201 if (web_contents_->GetDelegate() &&
211 web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse)) 202 web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse))
212 return; 203 return;
213 web_contents_->GetRenderWidgetHostView()->Focus(); 204 web_contents_->GetRenderWidgetHostView()->Focus();
214 } 205 }
215 206
216 } // namespace content 207 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_view_android.h ('k') | content/browser/web_contents/web_contents_view_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698